1619621 - Check if reflowFront is destroyed in untrackReflowsInSelection

Status: RESOLVED FIXED

(DevTools :: Inspector, task, P3)

Description

[Julian Descottes [:jdescottes]]

After supporting target switching in the inspector, the reflowFront reference can be destroyed when the corresponding target is destroyed.

https://searchfox.org/mozilla-central/rev/91f6c02fcf4c16f78fdc4417f61f192688294066/devtools/client/inspector/inspector.js#1540-1563

In untrackReflowsInSelection we should improve the guard to protect against cases where the reference is defined, but has been destroyed:

    if (!this.reflowFront) {
      return;
    }

should become

    if (!this.reflowFront || !this.reflowFront.actorID) {
      return;
    }

Alternatively we could nullify the reference, in onTargetDestroyed, but since the whole creation and usage of reflowFront is contained in track/untrackReflowsInSelection, I think it would be nice to keep it this way.

I don't plan to add tests for this because it will be tested with various other inspector target switching tests (from bug 1611096 and bug 1603170 for instance)

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1619621 - Check if reflowFront is destroyed in untrackReflowsInSelection

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8824039faaa
Check if reflowFront is destroyed in untrackReflowsInSelection r=ochameau,daisuke

Comment 3

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/c8824039faaa