1619658 - Design and implement an Enterprise Policy to control Picture-in-Picture

Status: RESOLVED FIXED

(Firefox :: Enterprise Policies, enhancement, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

Some institutions might not want Picture-in-Picture to be used on their machines. We should give system administrators control over the toggle.

Things to consider:

1. We might want to have the Enterprise Policy hook into the webcompat site-specific toggle position stuff we're already doing.
2. We might want to allow the Enterprise Policy to control the position of the toggle, as well as whether or not it's displayed.

Maybe Roman or mkaply have thoughts here, too.

Comment 1

[Mike Kaply [:mkaply]]

With the way you've implemented this (pretty much completely child side), I'm not sure it would be to insert policy into this equation.

There are no preferences except for turning it on/off, everything else seems to be basically content scripts.

I think we can add a basic on off toggling with locking and if it becomes more complex, we can add to that policy.

Comment 2

[Mike Kaply [:mkaply]]

Attachment: Bug 1619658 - Add picture in picture policy.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7daef473f5eb
Add picture in picture policy. r=fluent-reviewers,mconley,flod

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5bb98eb25269
Backed out changeset 7daef473f5eb for test_sorted_alphabetically.js failures CLOSED TREE

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset 7daef473f5eb (bug 1619658) for test_sorted_alphabetically.js failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=c5cAPvnVSZWEElgiXZPVfA-0&fromchange=7daef473f5ebb2fce0b58a82972cf7b4a8079ae8&tochange=92c11f0bf14b71b70bec5351212ae237707f4a62&searchStr=xpc

Backout link: https://hg.mozilla.org/integration/autoland/rev/5bb98eb252691b1aa5226360735fef4c078d7f8b

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=303247610&repo=autoland&lineNumber=5498

[task 2020-05-21T18:14:02.519Z] 18:14:02     INFO -  TEST-START | browser/components/enterprisepolicies/tests/xpcshell/test_sorted_alphabetically.js
[task 2020-05-21T18:14:02.885Z] 18:14:02  WARNING -  TEST-UNEXPECTED-FAIL | browser/components/enterprisepolicies/tests/xpcshell/test_sorted_alphabetically.js | xpcshell return code: 0
[task 2020-05-21T18:14:02.885Z] 18:14:02     INFO -  TEST-INFO took 358ms
[task 2020-05-21T18:14:02.885Z] 18:14:02     INFO -  >>>>>>>
[task 2020-05-21T18:14:02.885Z] 18:14:02     INFO -  PID 6672 | [6672, Main Thread] WARNING: Couldn't get the user appdata directory. Crash events may not be produced.: file /builds/worker/checkouts/gecko/toolkit/crashreporter/nsExceptionHandler.cpp, line 2924
[task 2020-05-21T18:14:02.885Z] 18:14:02     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2020-05-21T18:14:02.885Z] 18:14:02     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2020-05-21T18:14:02.885Z] 18:14:02     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2020-05-21T18:14:02.885Z] 18:14:02     INFO -  running event loop
[task 2020-05-21T18:14:02.885Z] 18:14:02     INFO -  browser/components/enterprisepolicies/tests/xpcshell/test_sorted_alphabetically.js | Starting test_policies_sorted
[task 2020-05-21T18:14:02.885Z] 18:14:02     INFO -  (xpcshell/head.js) | test test_policies_sorted pending (2)
[task 2020-05-21T18:14:02.885Z] 18:14:02  WARNING -  TEST-UNEXPECTED-FAIL | browser/components/enterprisepolicies/tests/xpcshell/test_sorted_alphabetically.js | test_policies_sorted - [test_policies_sorted : 18] policies-schema.json is alphabetically sorted. - false == true
[task 2020-05-21T18:14:02.885Z] 18:14:02     INFO -  /Users/cltbld/tasks/task_1590072898/build/tests/xpcshell/tests/browser/components/enterprisepolicies/tests/xpcshell/test_sorted_alphabetically.js:checkArrayIsSorted:18
[task 2020-05-21T18:14:02.886Z] 18:14:02     INFO -  /Users/cltbld/tasks/task_1590072898/build/tests/xpcshell/tests/browser/components/enterprisepolicies/tests/xpcshell/test_sorted_alphabetically.js:test_policies_sorted:29
[task 2020-05-21T18:14:02.886Z] 18:14:02     INFO -  /Users/cltbld/tasks/task_1590072898/build/tests/xpcshell/head.js:_run_next_test/<:1618
[task 2020-05-21T18:14:02.886Z] 18:14:02     INFO -  /Users/cltbld/tasks/task_1590072898/build/tests/xpcshell/head.js:_run_next_test:1618
[task 2020-05-21T18:14:02.886Z] 18:14:02     INFO -  /Users/cltbld/tasks/task_1590072898/build/tests/xpcshell/head.js:run:777
[task 2020-05-21T18:14:02.886Z] 18:14:02     INFO -  /Users/cltbld/tasks/task_1590072898/build/tests/xpcshell/head.js:_do_main:248
[task 2020-05-21T18:14:02.886Z] 18:14:02     INFO -  /Users/cltbld/tasks/task_1590072898/build/tests/xpcshell/head.js:_execute_test:577
[task 2020-05-21T18:14:02.886Z] 18:14:02     INFO -  -e:null:1
[task 2020-05-21T18:14:02.886Z] 18:14:02     INFO -  exiting test
[task 2020-05-21T18:14:02.886Z] 18:14:02     INFO -  (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2020-05-21T18:14:02.886Z] 18:14:02     INFO -  Unexpected exception NS_ERROR_ABORT:
[task 2020-05-21T18:14:02.887Z] 18:14:02     INFO -  _abort_failed_test@/Users/cltbld/tasks/task_1590072898/build/tests/xpcshell/head.js:833:20
[task 2020-05-21T18:14:02.887Z] 18:14:02     INFO -  do_report_result@/Users/cltbld/tasks/task_1590072898/build/tests/xpcshell/head.js:934:5
[task 2020-05-21T18:14:02.887Z] 18:14:02     INFO -  Assert<@/Users/cltbld/tasks/task_1590072898/build/tests/xpcshell/head.js:73:21
[task 2020-05-21T18:14:02.887Z] 18:14:02     INFO -  proto.report@resource://testing-common/Assert.jsm:233:10
[task 2020-05-21T18:14:02.887Z] 18:14:02     INFO -  proto.ok@resource://testing-common/Assert.jsm:259:10
[task 2020-05-21T18:14:02.887Z] 18:14:02     INFO -  checkArrayIsSorted@/Users/cltbld/tasks/task_1590072898/build/tests/xpcshell/tests/browser/components/enterprisepolicies/tests/xpcshell/test_sorted_alphabetically.js:18:5
[task 2020-05-21T18:14:02.887Z] 18:14:02     INFO -  test_policies_sorted@/Users/cltbld/tasks/task_1590072898/build/tests/xpcshell/tests/browser/components/enterprisepolicies/tests/xpcshell/test_sorted_alphabetically.js:29:21
[task 2020-05-21T18:14:02.887Z] 18:14:02     INFO -  _run_next_test/<@/Users/cltbld/tasks/task_1590072898/build/tests/xpcshell/head.js:1618:22
[task 2020-05-21T18:14:02.887Z] 18:14:02     INFO -  _run_next_test@/Users/cltbld/tasks/task_1590072898/build/tests/xpcshell/head.js:1618:38
[task 2020-05-21T18:14:02.887Z] 18:14:02     INFO -  run@/Users/cltbld/tasks/task_1590072898/build/tests/xpcshell/head.js:777:9
[task 2020-05-21T18:14:02.888Z] 18:14:02     INFO -  _do_main@/Users/cltbld/tasks/task_1590072898/build/tests/xpcshell/head.js:248:6
[task 2020-05-21T18:14:02.888Z] 18:14:02     INFO -  _execute_test@/Users/cltbld/tasks/task_1590072898/build/tests/xpcshell/head.js:577:5
[task 2020-05-21T18:14:02.888Z] 18:14:02     INFO -  @-e:1:1
[task 2020-05-21T18:14:02.888Z] 18:14:02     INFO -  exiting test
[task 2020-05-21T18:14:02.888Z] 18:14:02     INFO -  PID 6672 | [6672, Main Thread] WARNING: Extra shutdown CC: 'i < NORMAL_SHUTDOWN_COLLECTIONS', file /builds/worker/checkouts/gecko/xpcom/base/nsCycleCollector.cpp, line 3359
[task 2020-05-21T18:14:02.889Z] 18:14:02     INFO -  PID 6672 | [6672, Main Thread] WARNING: OOPDeinit() without successful OOPInit(): file /builds/worker/checkouts/gecko/toolkit/crashreporter/nsExceptionHandler.cpp, line 3370
[task 2020-05-21T18:14:02.889Z] 18:14:02     INFO -  PID 6672 | [6672, Main Thread] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/worker/checkouts/gecko/xpcom/base/nsTraceRefcnt.cpp, line 202
[task 2020-05-21T18:14:02.889Z] 18:14:02     INFO -  PID 6672 | [6672, Main Thread] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/worker/checkouts/gecko/xpcom/base/nsTraceRefcnt.cpp, line 202
[task 2020-05-21T18:14:02.889Z] 18:14:02     INFO -  <<<<<<<

Comment 6

[Mike Kaply [:mkaply]]

Dumb mistake on my part. New patch landing. I've tested this locally.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fdfb16cb82a6
Add picture in picture policy. r=fluent-reviewers,mconley,flod

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a5c5a7a3cf83
Add picture in picture policy.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b31e67c062b
Backed out 2 changesets for xpc and linting failures.
https://hg.mozilla.org/integration/autoland/rev/fac6421d395d
Add picture in picture policy. r=fluent-reviewers,mconley,flod

Comment 10

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/fac6421d395d