1619676 - Raise the priority of content processes that are being shut down

Status: RESOLVED INVALID

(Core :: DOM: Content Processes, enhancement)

Description

[Gabriele Svelto [:gsvelto]]

In bug 1366356 we made sure that a content process not running a foreground tab had its CPU priority demoted. During content process shutdown this can be problematic, as the content process might not be allocated enough CPU time and will get killed instead of shutting down cleanly.

We should raise the CPU priority of a content process right before we send it the IPC shutdown message to make sure it'll have time to shut down cleanly.

Comment 1

[Andrew McCreight [:mccr8]]

This feels a little backwards to me. Why are we potentially janking foreground tabs to avoid shutdown hang kills users don't even notice? You could also do something like increase the hang timeout if they are a real issue.

Comment 2

[Alex Thayer [:alexical] (she/her)]

My inclination is to agree with Andrew except in the case where we're shutting down the whole browser, since we block the parent process waiting for content processes to shut down.

Comment 3

[Gabriele Svelto [:gsvelto]]

Alright, I hadn't considered the possibility that this would jank foreground processes but indeed that's the case, so I'm closing this as INVALID.