Open Bug 1619749 Opened 5 years ago Updated 2 years ago

Investigate AutoMaybeDisableFontInflation behaviour

Categories

(Core :: Layout: Text and Fonts, task)

task

Tracking

()

People

(Reporter: JanH, Unassigned)

Details

At the moment, certain size calculations (certainly for intrinsic sizes, maybe some other edge cases, too?) always happen without considering the influence of font inflation if the frame in questions happens to be a font inflation container.
The main reason is presumably to prevent circular dependencies where the frame size depends on the amount of font inflation, but the amount of font inflation in turn depends on the width of that very frame whose size we're trying to determine.

AutoMaybeDisableFontInflation has a comment that says that it could run probably less often since the switch to base font inflation calculations on the ISize of the respective "flow root's NCA's (nearest common ancestor of its inflatable descendants)", which seems to point towards the fact that it might be sufficient to only turn off font inflation for intrinsic size calculations when actually looking at an NCA (where we actually have a circular dependency between font inflation magnitude and frame width), instead of for every inflation container.

So the task at hand is to check

  1. whether the above is actually true, or whether there are some more edge cases where font inflation still shouldn't be considered during size calculations, and
  2. whether changing our logic in that way really is an improvement in terms of the resulting effect on pages, or whether it might actually make our font inflation behaviour worse in some cases.
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.