Open Bug 1619777 Opened 4 years ago Updated 2 years ago

[RTL] The minimize button is 2px too far from the other controls, on Windows 7 Aero Basic

Categories

(Firefox :: Theme, defect, P3)

Unspecified
Windows 7
defect

Tracking

()

People

(Reporter: itiel_yn8, Unassigned)

References

Details

(Keywords: rtl)

Attachments

(2 files)

2.03 KB, image/png
Details
2.15 KB, image/png
Details
Attached image LTR

See attached for how this looks on RTL and LTR.

Attached image RTL

This is because of this rule taking effect:
https://searchfox.org/mozilla-central/rev/91f6c02fcf4c16f78fdc4417f61f192688294066/browser/themes/windows/browser.css#334
Without it the issue is fixed on RTL but on LTR the button will be too close to other other controls.
We can slap a :dir(ltr) to that rule but this doesn't feel like the right solution.

Dão, any idea why in RTL the spacing looks fine without this rule but in LTR they're too close, or what would be the correct solution?

Flags: needinfo?(dao+bmo)

This is Aero Basic, not Classic.

I think this might have to do with nsNativeThemeWin.cpp not being direction-aware here: https://searchfox.org/mozilla-central/rev/d5b34cc8872177d3ee071e06f787c2a14268595b/widget/windows/nsNativeThemeWin.cpp#296-354

Blocks: 606160
Flags: needinfo?(dao+bmo)
Keywords: rtl
OS: Unspecified → Windows 7
Priority: -- → P3
Summary: [RTL] The minimize button is 2px too far from the other controls, on Windows 7 classic → [RTL] The minimize button is 2px too far from the other controls, on Windows 7 Aero Basic
See Also: → 1628342
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: