1619778 - UnsatisfiedLinkError: No implementation found for org.mozilla.geckoview.Base64Utils.encode(byte[])

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[Jonathan Almeida [:jonalmeida]]

https://sentry.prod.mozaws.net/operations/reference-browser/issues/7413691/

UnsatisfiedLinkError: No implementation found for java.lang.String org.mozilla.geckoview.Base64Utils.encode(byte[]) (tried Java_org_mozilla_geckoview_Base64Utils_encode and Java_org_mozilla_geckoview_Base64Utils_encode___3B)
    at org.mozilla.reference.browser.push.WebPushEngineIntegration$onMessageReceived$1.invokeSuspend(WebPushEngineIntegration.kt:40)
...
(8 additional frame(s) were not displayed)

No implementation found for java.lang.String org.mozilla.geckoview.Base64Utils.encode(byte[]) (tried Java_org_mozilla_geckoview_Base64Utils_encode and Java_org_mozilla_geckoview_Base64Utils_encode___3B)

Looks like it's pointing at this reference of Base64Utils in GV.

This was on a Pixel 4 (arm64, Android 10) and SM-G955F (Android 9) so far.

Comment 1

[Jonathan Almeida [:jonalmeida]]

We're seeing a lot more crashes from this now that WebPush is integrated into Fenix Nightly. Would it be possible to get this triaged sooner?

Fenix crash issue (with linked Sentry report): https://github.com/mozilla-mobile/fenix/issues/9113

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Yeah, this should be an easy fix. I'll take it.

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1619778 - Remove unused `GeckoThread#waitOnGecko` methods.

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1619778 - Add `GeckoThread#waitForState()`.

This allows us to asynchronously wait for a given GeckoThread state
to be reached.

Comment 5

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1619778 - Wait for Gecko to be ready when delivering Web Push events

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b51291b425c
Remove unused `GeckoThread#waitOnGecko` methods. r=geckoview-reviewers,aklotz
https://hg.mozilla.org/integration/autoland/rev/f0bca273ad0e
Add `GeckoThread#waitForState()`. r=geckoview-reviewers,aklotz
https://hg.mozilla.org/integration/autoland/rev/fe284afeeb48
Wait for Gecko to be ready when delivering Web Push events r=geckoview-reviewers,aklotz

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/6b51291b425c
https://hg.mozilla.org/mozilla-central/rev/f0bca273ad0e
https://hg.mozilla.org/mozilla-central/rev/fe284afeeb48

Comment 8

[Jonathan Almeida [:jonalmeida]]

No longer seeing new crashes, thanks snorp!

Comment 9

[Chenxia Liu [:liuche]]

Comment on attachment 9132896 [details]
Bug 1619778 - Remove unused GeckoThread#waitOnGecko methods.

Beta/Release Uplift Approval Request

• User impact if declined: Part 1-3: Currently the top crasher on Firefox Preview 4.1, and will likely be a top crasher for Fennec Beta Migration
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1619778
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Removing unused code, and adding a wait/log around crashing code.

:snorp can correct me if I'm wrong about the riskiness of this patch series.

• String changes made/needed:

Comment 10

[Chenxia Liu [:liuche]]

cc snorp, who wrote this change and can say if this is too risky to need beta uplift. I just want the crashes to come down :)

Comment 11

[James Willcox (:snorp) ([e-mail]) (he/him)]

Yeah, this should be fine to uplift.

Comment 12

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 9132896 [details]
Bug 1619778 - Remove unused GeckoThread#waitOnGecko methods.

geckoview crash fix, approved for 75.0b10

Comment 13

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/bb8f832e48dc
https://hg.mozilla.org/releases/mozilla-beta/rev/b8069adfb9ac
https://hg.mozilla.org/releases/mozilla-beta/rev/45be288db1b7