1619883 - Don't include spellchecker dictionary in omni.ja of GeckoView

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P1)

Description

[Makoto Kato [:m_kato]]

Actually, we don't turn on hunspell spellchecker for Android, but, omni.ja seems have hunspell's dictionary.

makoto$ unzip -vl omni.ja  | grep -i en-US
    3074  Defl:X      970  68% 01-01-2010 00:00 efab1c90  dictionaries/en-US.aff
  586387  Defl:X   201822  66% 01-01-2010 00:00 ec359f3f  dictionaries/en-US.dic

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1619883 - Don't include spellchecker dictionary in omni.ja of GeckoView.

Actually, we don't turn on hunspell spellchecker for Android, but, omni.ja seems have hunspell's dictionary. Let's remove it from package.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c28df02dc2b
Don't include spellchecker dictionary in omni.ja of GeckoView. r=geckoview-reviewers,agi

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/6c28df02dc2b

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

We do still build spellchecker and hunspell for Android though, right? At least I see the relevant .o files in android objdir.
Do you think we could avoid building those?

Comment 5

[Makoto Kato [:m_kato]]

(In reply to Olli Pettay [:smaug][[e-mail]] from comment #4)

We do still build spellchecker and hunspell for Android though, right? At least I see the relevant .o files in android objdir.
Do you think we could avoid building those?

Right. Since hunspell is a XPCOM service as mozISpellCheckingEngine, we can avoid to build it on GeckoView.