1619921 - [clang-plugin] Add the possibility to have `alpha-checkers` that are not enabled by default for clang based static-analysis

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, enhancement)

Description

[Andi [:andi]]

Right now we don't have the possibility to have in-tree checkers that detect issues but also add unwanted noise.
By many the extra noise is considered to annoy more than to have a good impact of code quality so we must be an architecture where we allow this sort of checkers to land and be enabled by additional flags to --enable-clang-plugin.
For this we add a new flag --enabble-clang-plugin-alpha that enables checkers that will be deployed in build/clang-plugin/alpha.
With time the checkers from the alpha channel will be updated thus eliminating the unwanted noise and they can be promoted to the main channel that is enabled with --enable-clang-plugin.

Comment 1

[Andi [:andi]]

Attachment: Bug 1619921 - enable clang-plugin with support for alpha checkers module.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/780399392e20
enable clang-plugin with support for alpha checkers module. r=froydnj,sg

Comment 3

[Andreea Pavel [:apavel]]

Backed out for failing toolchain

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=780399392e205838a051b152a842a6a0765ae4ed&selectedJob=293349590

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=293349590&repo=autoland&lineNumber=366

Backout: https://hg.mozilla.org/integration/autoland/rev/5309cad776949196162e120eed704c39e49a92d5

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b2eecba3bb0
enable clang-plugin with support for alpha checkers module. r=froydnj,sg

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/2b2eecba3bb0