Closed Bug 1620069 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 22092 - [webauthn] WPT - adding port to RP ID should fail

Categories

(Core :: DOM: Web Authentication, task, P4)

Product:
Core
Component:
DOM: Web Authentication
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla76
Tracking Flags:
Tracking Status
firefox76 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 22092 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/22092
Details from upstream follow.

Nina Satragno <nsatragno@chromium.org> wrote:

[webauthn] WPT - adding port to RP ID should fail

Relying party IDs are defined as "a registrable domain suffix of or
equal to the caller’s origin's effective domain". RP IDs do not include
a port.

This patch changes the host + port subtests to expect a failure instead
of success.

Bug: 875444
Change-Id: I0067ebd883612d534df13a555284fe1cdec7424d
Reviewed-on: https://chromium-review.googlesource.com/2088002
WPT-Export-Revision: b108464beb053d6214d6f6ab270c7dace6020d4e

Component: web-platform-tests → DOM: Web Authentication
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 50 tests

Status Summary

Firefox

PASS : 10[GitHub] 46[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]
FAIL : 1
TIMEOUT: 8
NOTRUN : 51

Chrome

OK : 4
PASS : 68
FAIL : 2

Safari

PASS : 4
FAIL : 1
TIMEOUT: 4
ERROR : 2
NOTRUN : 42

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webauthn/createcredential-badargs-rp.https.html: SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt], TIMEOUT [GitHub] (Chrome: OK, Safari: TIMEOUT)
Bad rp: icon is insecure: TIMEOUT (Chrome: PASS, Safari: NOTRUN)
Bad rp: rp null: FAIL (Chrome: PASS, Safari: FAIL)
/webauthn/createcredential-passing.https.html: SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt], TIMEOUT [GitHub] (Chrome: OK, Safari: TIMEOUT)
passing credentials.create() with rpId (hostname): NOTRUN (Chrome: PASS, Safari: NOTRUN)
attestation parameter: attestation is "none": NOTRUN (Chrome: PASS, Safari: NOTRUN)
Float32Array user id: NOTRUN (Chrome: PASS, Safari: NOTRUN)
authenticatorSelection is empty object: NOTRUN (Chrome: PASS, Safari: NOTRUN)
attestation parameter: attestation is undefined: NOTRUN (Chrome: PASS, Safari: NOTRUN)
authenticatorSelection residentKey false: NOTRUN (Chrome: PASS, Safari: NOTRUN)
passing credentials.create() with no timeout: NOTRUN (Chrome: PASS, Safari: NOTRUN)
Float32Array challenge: NOTRUN (Chrome: PASS, Safari: NOTRUN)
extensions are dict of empty strings: NOTRUN (Chrome: PASS, Safari: NOTRUN)
authenticatorSelection attachment undefined: NOTRUN (Chrome: PASS, Safari: NOTRUN)
attestation parameter: attestation is "direct": NOTRUN (Chrome: PASS, Safari: NOTRUN)
Int32Array challenge: NOTRUN (Chrome: PASS, Safari: NOTRUN)
passing credentials.create() without user.icon: NOTRUN (Chrome: PASS, Safari: NOTRUN)
attestation parameter: attestation is "indirect": NOTRUN (Chrome: PASS, Safari: NOTRUN)
Int16Array user id: NOTRUN (Chrome: PASS, Safari: NOTRUN)
authenticatorSelection residentKey undefined: NOTRUN (Chrome: PASS, Safari: NOTRUN)
max length user id: NOTRUN (Chrome: PASS, Safari: NOTRUN)
authenticatorSelection userVerification undefined: NOTRUN (Chrome: PASS, Safari: NOTRUN)
Float64Array challenge: NOTRUN (Chrome: PASS, Safari: NOTRUN)
EC256 pubKeyCredParams: NOTRUN (Chrome: PASS, Safari: NOTRUN)
Uint8Array user id: NOTRUN (Chrome: PASS, Safari: NOTRUN)
DataView user id: NOTRUN (Chrome: PASS, Safari: NOTRUN)
authenticatorSelection is undefined: NOTRUN (Chrome: PASS, Safari: NOTRUN)
extensions undefined: NOTRUN (Chrome: PASS, Safari: NOTRUN)
SelectEC256 pubKeyCredParams from a list: NOTRUN (Chrome: PASS, Safari: NOTRUN)
passing credentials.create() without rp.icon: NOTRUN (Chrome: PASS, Safari: NOTRUN)
passing credentials.create() with default arguments: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
Int32Array user id: NOTRUN (Chrome: PASS, Safari: NOTRUN)
Bad pubKeyCredParams: pubKeyCredParams is empty Array: NOTRUN (Chrome: FAIL, Safari: NOTRUN)
Int16Array challenge: NOTRUN (Chrome: PASS, Safari: NOTRUN)
extensions are empty object: NOTRUN (Chrome: PASS, Safari: NOTRUN)
DataView challenge: NOTRUN (Chrome: PASS, Safari: NOTRUN)
authenticatorSelection userVerification discouraged: NOTRUN (Chrome: PASS, Safari: NOTRUN)
very short user id: NOTRUN (Chrome: PASS, Safari: NOTRUN)
Int8Array user id: NOTRUN (Chrome: PASS, Safari: NOTRUN)
authenticatorSelection default values: NOTRUN (Chrome: PASS, Safari: NOTRUN)
Absurdly large challenge: NOTRUN (Chrome: PASS, Safari: NOTRUN)
/webauthn/getcredential-badargs-rpid.https.html: SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt], TIMEOUT [GitHub] (Chrome: OK, Safari: ERROR)
Bad rpId: null: NOTRUN (Chrome: PASS)
Bad rpId: invalid domain (starts with dash): NOTRUN (Chrome: PASS)
Bad rpId: empty string: TIMEOUT (Chrome: PASS)
Bad rpId: host + port: NOTRUN (Chrome: PASS)
Bad rpId: invalid domain (has space): NOTRUN (Chrome: PASS)
Bad rpId: invalid domain (starts with number): NOTRUN (Chrome: PASS)
/webauthn/getcredential-passing.https.html: SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt], TIMEOUT [GitHub] (Chrome: OK, Safari: ERROR)
authenticatorSelection userVerification preferred: NOTRUN (Chrome: PASS)
passing credentials.create() with no timeout: NOTRUN (Chrome: PASS)
extensions are dict of empty strings: NOTRUN (Chrome: PASS)
rpId undefined: NOTRUN (Chrome: PASS)
passing credentials.get() with default args: TIMEOUT (Chrome: PASS)
extensions undefined: NOTRUN (Chrome: PASS)
extensions are empty object: NOTRUN (Chrome: PASS)
authenticatorSelection userVerification discouraged: NOTRUN (Chrome: PASS)
no credential specified: NOTRUN (Chrome: FAIL)
authenticatorSelection userVerification undefined: NOTRUN (Chrome: PASS)
passing credentials.get() with rpId (hostname): NOTRUN (Chrome: PASS)

Tests Disabled in Gecko Infrastructure

/webauthn/createcredential-badargs-rp.https.html: SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt], TIMEOUT [GitHub] (Chrome: OK, Safari: TIMEOUT)
/webauthn/createcredential-passing.https.html: SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt], TIMEOUT [GitHub] (Chrome: OK, Safari: TIMEOUT)
/webauthn/getcredential-badargs-rpid.https.html: SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt], TIMEOUT [GitHub] (Chrome: OK, Safari: ERROR)
/webauthn/getcredential-passing.https.html: SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt], TIMEOUT [GitHub] (Chrome: OK, Safari: ERROR)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/14c68e98e006
[wpt PR 22092] - [webauthn] WPT - adding port to RP ID should fail, a=testonly

https://hg.mozilla.org/mozilla-central/rev/14c68e98e006

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox76: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.