1620137 - Small Input in Password Required Pop-up

Status: VERIFIED FIXED

(Toolkit Graveyard :: Notifications and Alerts, defect)

Description

[erosman]

Attachment: Password Required Pop-up.jpg

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:75.0) Gecko/20100101 Firefox/75.0

Steps to reproduce:

In the last 2 updates (both applied one after the other so I don't know which one is the reason), the input field in Password Required Pop-up has shrunk per attached screenshot.

Comment 1

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ff64ebd45330c02e50fb757865f2c682b3f20012&tochange=936b10b881e6302509e4f1d5968926dd4fcecaad

Comment 2

[:Gijs (he/him)]

[Tracking Requested - why for this release]:
User-visible regression in dialog boxes

I expect the box's container needs moz-box-align: stretch or something.

Comment 3

[Tim Nguyen :ntim]

Attachment: Bug 1620137 - Make #dialogGrid wrapper a <div> instead of a <box>.

Comment 4

[Tim Nguyen :ntim]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c13828023a9ded8c30c7879f867ca4e6e6172afb

Comment 5

[:Gijs (he/him)]

Need to test this on my windows machine.

Comment 6

[:Gijs (he/him)]

(In reply to :Gijs (he/him) from comment #5)

Need to test this on my windows machine.

I tried, but I can't verify that this helps because even if I back out the regressing bug I don't see wrapping text in the testcase in the regressing bug.

Alice, can you check if the trypush at https://treeherder.mozilla.org/#/jobs?repo=try&revision=c13828023a9ded8c30c7879f867ca4e6e6172afb reintroduces bug 1606617 for you?

Comment 7

[Alice0775 White]

(In reply to :Gijs (he/him) from comment #6)

(In reply to :Gijs (he/him) from comment #5)

Need to test this on my windows machine.

I tried, but I can't verify that this helps because even if I back out the regressing bug I don't see wrapping text in the testcase in the regressing bug.

Alice, can you check if the trypush at https://treeherder.mozilla.org/#/jobs?repo=try&revision=c13828023a9ded8c30c7879f867ca4e6e6172afb reintroduces bug 1606617 for you

This bug is fixed on the try-build.
However, Bug 1606617 is back on the try-build. Descriptions and buttons overlap each other.

Comment 8

[Tim Nguyen :ntim]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3934eba8139f55d77d2b603b18745d51355de56e

Comment 9

[Alice0775 White]

(In reply to Tim Nguyen :ntim from comment #8)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3934eba8139f55d77d2b603b18745d51355de56e

This bug and Bug 1606617(overlap issue) are fixed on the try-build.
However, the button cut off issue is back...

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1fc93d698058
Make #dialogGrid wrapper a <div> instead of a <box>. r=Gijs

Comment 11

[Tim Nguyen :ntim]

(In reply to Alice0775 White from comment #9)

(In reply to Tim Nguyen :ntim from comment #8)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3934eba8139f55d77d2b603b18745d51355de56e

This bug and Bug 1606617(overlap issue) are fixed on the try-build.
However, the button cut off issue is back...

Thanks for testing! I filed bug 1620575 to address the cut-off, since this is unfortunately tricky to fix.

Comment 12

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/1fc93d698058

Comment 13

[Camelia Badau [:cbadau], Desktop QA]

I'm not able to reproduce the issue on Windows 7 x64 and Windows 10 x64 using Firefox Nightly 75.0a1 (2020-03-04).

Can you please verify that the issue is fixed in the latest Beta build? You can download the Beta build from the following link: https://archive.mozilla.org/pub/firefox/candidates/75.0b6-candidates/build1/

Thanks!

Comment 14

[Alice0775 White]

I can not reproduce on 75.0b4 as well as Nightly76.0a1(20200320095353) windows10.

Comment 15

[erosman]

AFA I recall it was fixed. I am currently on 76.0a1 (2020-03-19) (64-bit)

Comment 16

[:Gijs (he/him)]

Thanks, Alice & erosman!