1620197 - Enable multiple results from WebAssembly functions

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, enhancement, P2)

Description

[Andy Wingo [:wingo]]

The patch to be attached will enable validation of wasm modules with functions that return multiple values, as the baseline and ion compilers are all wired up now.

Comment 1

[Andy Wingo [:wingo]]

Attachment: Bug 1620197 - Enable multiple results from WebAssembly functions

This patch enables multi-value calls and returns, adding some tests, and
conditionally disabling a couple expect-fail reftests that now pass.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e71e54d93af8
Enable multiple results from WebAssembly functions r=lth

Comment 3

[Stefan Hindli [:stefan_hindli]]

Backed out changeset e71e54d93af8 (Bug 1620197) for spidermonkey build bustages CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=8b964151a6aab562e4b12e07ca4c60b7266289c3&selectedJob=291996745

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=291996745&repo=autoland&lineNumber=88712

Comment 4

[Andy Wingo [:wingo]]

Thanks, looking at it.

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f44f0236dd55
Backed out changeset e71e54d93af8 for spidermonkey build bustages CLOSED TREE

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/455f2bae38f3
Enable multiple results from WebAssembly functions r=lth

Comment 7

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/455f2bae38f3

Comment 8

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 455f2bae38f3 (Bug 1620197) for sm bustage on call-run.js.
The bustage appeared on mc after the merge.
https://hg.mozilla.org/integration/autoland/rev/edff668bc00397d485aeb91cfe456783e26c212b

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&selectedJob=292353644&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception

https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&selectedJob=292353657&resultStatus=superseded%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&searchStr=windows%2C2012%2Cdebug%2Cspidermonkey%2Cbuilds%2Cspidermonkey-sm-plain-win32%2Fdebug%2Csm%28p%29&revision=268543e53e1b11ce0e468d985ea3777563e7b8a8

Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=292353644&repo=mozilla-central&lineNumber=45004

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=292353657&repo=mozilla-central&lineNumber=45286

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/edff668bc003

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16fd9844f2d2
Enable multiple results from WebAssembly functions r=lth

Comment 11

[Cristina Coroiu [:ccoroiu]]

Backed out changeset 16fd9844f2d2 (bug 1620197) for SM failure at /src/js/src/jit/RegisterAllocator.cpp

Backout: https://hg.mozilla.org/integration/autoland/rev/7f2750e6e75d5a00d973930f92edaecc11c39e54

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=16fd9844f2d2029feaba3c864b1a0f830f9da235

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=293658815&repo=autoland&lineNumber=44630

Comment 12

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/16fd9844f2d2

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/920da79f43fc
Enable multiple results from WebAssembly functions r=lth

Comment 14

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/920da79f43fc

Comment 15

[Andy Wingo [:wingo]]

All good. Thanks sheriffs for patience!