1620198 - Remove mozIStorageAggregateFunction

Status: RESOLVED FIXED

(Core :: SQLite and Embedded Database Bindings, task, P3)

Description

[Simon Giesecke [:sg] [he/him]]

mozIStorageAggregateFunction is not used (outside of unit tests), so it could be removed.

If it is removed, Bug 546382 can be closed.

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1620198 - Part 1: Remove CreateAggregateFunction. r=asuth

Depends on D65504

Comment 2

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1620198 - Part 2: Remove FunctionInfo::type. r=asuth

Depends on D65505

Comment 3

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1620198 - Part 3: Change type of FunctionInfo::function to nsCOMPtr<mozIStorageFunction>. r=asuth

Depends on D65506

Comment 4

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1620198 - Part 4: Remove mozIStorageAggregateFunction. r=asuth

Depends on D65507

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:sg, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 6

[Simon Giesecke [:sg] [he/him]]

I need to rebase the patches to make them independent of the (stalled) changes made for Bug 1603703

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/78cfc90ddc90
Part 1: Remove CreateAggregateFunction. r=asuth
https://hg.mozilla.org/integration/autoland/rev/dd723bc69b7f
Part 2: Remove FunctionInfo::type. r=asuth
https://hg.mozilla.org/integration/autoland/rev/356cb72fa1ef
Part 3: Change type of FunctionInfo::function to nsCOMPtr<mozIStorageFunction>. r=asuth
https://hg.mozilla.org/integration/autoland/rev/3537ee799385
Part 4: Remove mozIStorageAggregateFunction. r=asuth

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/78cfc90ddc90
https://hg.mozilla.org/mozilla-central/rev/dd723bc69b7f
https://hg.mozilla.org/mozilla-central/rev/356cb72fa1ef
https://hg.mozilla.org/mozilla-central/rev/3537ee799385