1620239 - TypeError: can't access property "externalContentPolicyType", channel.loadInfo is null

Status: RESOLVED FIXED

(Core :: Networking, defect, P3)

Description

[Florian Quèze [:florian]]

I see lots of TypeError: can't access property "externalContentPolicyType", channel.loadInfo is null errors in the browser console when loading web pages, eg. when typing https://profiler.firefox.com and <enter> in the url bar.

The error is on this line https://searchfox.org/mozilla-central/rev/c79c0d65a183d9d38676855f455a5c6a7f7dadd3/browser/components/search/SearchTelemetry.jsm#658 added by bug 1614777.

Comment 1

[Ethan Tseng [:ethan]]

Gary, can you please look into this issue?

Comment 2

[Gary Chen [:xeonchen]]

Attachment: Bug 1620239 - ensure not to access null pointer;

Comment 3

[(no longer active)]

Out of curiosity, what channel was it that didn't have loadinfo?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1843cd41ed4f
ensure not to access null pointer; r=Ehsan

Comment 5

[Gary Chen [:xeonchen]]

(In reply to :ehsan akhgari from comment #3)

Out of curiosity, what channel was it that didn't have loadinfo?

I can't actually reproduce this, but according to ChannelWrapper.h it's not impossible to retrieve a null pointer when the channel is closed, which is not likely the case happen here.

Florian, any idea?

Comment 6

[Florian Quèze [:florian]]

Any idea about how I would go from plenty of noise in my console to answering the "what channel was it" question? I see this error everytime I capture a profile (ctrl+shift+2).

Comment 7

[Gary Chen [:xeonchen]]

(In reply to Florian Quèze [:florian] from comment #6)

Any idea about how I would go from plenty of noise in my console to answering the "what channel was it" question? I see this error everytime I capture a profile (ctrl+shift+2).

Thanks! I can reproduce while capturing a profile.
Looks like the given channel is invalid because the finalURL field is empty.

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/1843cd41ed4f