Allow specifiying source-test dependent-build-platform in task
Categories
(Firefox Build System :: Task Configuration, enhancement)
Tracking
(firefox77 fixed)
Tracking | Status | |
---|---|---|
firefox77 | --- | fixed |
People
(Reporter: jgraham, Assigned: jgraham)
Details
Attachments
(1 file)
Currently source-test tasks that require a build have to specify the dependent-build-platforms
in kind.yml
. This is OK if all the source-tests require the same kind of builds, but in practice they don't. In particular the remote agent wants opt builds but doesn't need PGO, and requiring that makes the turnaround unacceptably slow. We can solve that by defining a different platform string, but that feels like a workaround for the problem that this configuration is really per-task not per-type.
Instead we should just define dependent-build-platforms in the task definition itself.
Comment 1•5 years ago
|
||
Previously source-tests requiring a build had a "global" mapping of
platform to build type in kind.yml. But this made it confusing to
figure out how to add task-specific configuration. To simplify things,
make the configuration for the dependent platforms also go in the task
definition.
Updated•5 years ago
|
Updated•5 years ago
|
Comment 2•5 years ago
|
||
Sorry, I pushed that revision by accident. It's actually Jame's work. Jame, do you want to propose it? It's a huge help for me on a daily basis.
Assignee | ||
Comment 3•5 years ago
|
||
I'm very happy to land it if it works, but I'm a little worried that we don't have the same configuration on all platforms. ahal: do you know if this is going to work across all branches (i.e. do we have opt and shippable everywhere) or do we need to key on that somehow?
Comment 4•5 years ago
|
||
I'm not sure I understand the question.. Can't we set this up such that the resulting taskgraph is identical? I agree this patch makes a lot more sense than the dependent-build-platforms
key in kind.yml
.
I'd like to see something like:
require-build:
by-platform:
linux64.*: linux64-shippable/opt
default: null
Updated•5 years ago
|
Comment 6•5 years ago
|
||
bugherder |
Description
•