1620322 - Refactor AntiTrackingCommon.cpp

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, task)

Description

[(no longer active)]

This file has turned into a mess, it is time to refactor it.

Comment 1

[(no longer active)]

Attachment: Bug 1620322 - Part 1: Refactor the code for content blocking allow list out of AntiTrackingCommon.cpp;

Comment 2

[(no longer active)]

Attachment: Bug 1620322 - Part 2: Refactor the code for content blocking events and notifications out of AntiTrackingCommon.cpp;

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a4ad2ed5c4ab
Part 1: Refactor the code for content blocking allow list out of AntiTrackingCommon.cpp; r=baku

Comment 4

[(no longer active)]

Attachment: Bug 1620322 - Part 3: Move MaybeGetDocumentURIBeingLoaded to AntiTrackingUtils;

Comment 5

[(no longer active)]

Attachment: Bug 1620322 - Part 4: Refactor the code for the redirect heuristic out of AntiTrackingCommon.cpp;

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a4ad2ed5c4ab

Comment 7

[(no longer active)]

Attachment: Bug 1620322 - Part 5: Refactor the code for calculating the permission type string to AntiTrackingUtils;

Comment 8

[(no longer active)]

Attachment: Bug 1620322 - Part 6: Refactor the code related to user interactions out of AntiTrackingCommon.cpp;

Comment 9

[(no longer active)]

Attachment: Bug 1620322 - Part 7: Move TemporaryAccessGrantObserver out of AntiTrackingCommon.cpp;

Comment 10

[(no longer active)]

Attachment: Bug 1620322 - Part 8: Rename AntiTrackingCommon to ContentBlocking;

Comment 11

[(no longer active)]

Attachment: Bug 1620322 - Part 9: Move ContentBlockingLog to antitracking to keep all related code together in the same place;

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60ff34db9f15
Part 2: Refactor the code for content blocking events and notifications out of AntiTrackingCommon.cpp; r=baku
https://hg.mozilla.org/integration/autoland/rev/6802c18b1914
Part 3: Move MaybeGetDocumentURIBeingLoaded to AntiTrackingUtils; r=baku
https://hg.mozilla.org/integration/autoland/rev/659270edd419
Part 4: Refactor the code for the redirect heuristic out of AntiTrackingCommon.cpp; r=baku
https://hg.mozilla.org/integration/autoland/rev/4533bb4e5177
Part 5: Refactor the code for calculating the permission type string to AntiTrackingUtils; r=baku
https://hg.mozilla.org/integration/autoland/rev/72d640fa0740
Part 6: Refactor the code related to user interactions out of AntiTrackingCommon.cpp; r=baku
https://hg.mozilla.org/integration/autoland/rev/0eb2b5f7322f
Part 7: Move TemporaryAccessGrantObserver out of AntiTrackingCommon.cpp; r=baku
https://hg.mozilla.org/integration/autoland/rev/46714855ce1d
Part 8: Rename AntiTrackingCommon to ContentBlocking; r=baku
https://hg.mozilla.org/integration/autoland/rev/3dcf513e36cb
Part 9: Move ContentBlockingLog to antitracking to keep all related code together in the same place; r=baku

Comment 13

[Noemi Erli[:noemi_erli]]

Backed out 8 changesets (Bug 1620322) for causing bustages in ContentBlockingLog.cpp CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedJob=292302675&resultStatus=testfailed%2Cbusted%2Cexception&revision=3dcf513e36cbc64603b646900a4454dcfb59a84a

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=292302675&repo=autoland&lineNumber=42055

Backout: https://hg.mozilla.org/integration/autoland/rev/bb9e8ca59f3828e6eba137a80640727f2364ed2d

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31b24d79db3d
Part 2: Refactor the code for content blocking events and notifications out of AntiTrackingCommon.cpp; r=baku
https://hg.mozilla.org/integration/autoland/rev/0e5e5d41597d
Part 3: Move MaybeGetDocumentURIBeingLoaded to AntiTrackingUtils; r=baku
https://hg.mozilla.org/integration/autoland/rev/473bba698e5a
Part 4: Refactor the code for the redirect heuristic out of AntiTrackingCommon.cpp; r=baku
https://hg.mozilla.org/integration/autoland/rev/4e1e8b9afa1a
Part 5: Refactor the code for calculating the permission type string to AntiTrackingUtils; r=baku
https://hg.mozilla.org/integration/autoland/rev/ead3484ffb5f
Part 6: Refactor the code related to user interactions out of AntiTrackingCommon.cpp; r=baku
https://hg.mozilla.org/integration/autoland/rev/a916987c7c71
Part 7: Move TemporaryAccessGrantObserver out of AntiTrackingCommon.cpp; r=baku
https://hg.mozilla.org/integration/autoland/rev/be942a7f329e
Part 8: Rename AntiTrackingCommon to ContentBlocking; r=baku
https://hg.mozilla.org/integration/autoland/rev/f41739c64dff
Part 9: Move ContentBlockingLog to antitracking to keep all related code together in the same place; r=baku

Comment 15

[Narcis Beleuzu [:NarcisB]]

Backed out for bustages on nsContentSink.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/5b47cfcab1554c89400b7a6299ff0cabac4bda0c
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=292339774&repo=autoland&lineNumber=30057

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66b3bf7917f1
Part 2: Refactor the code for content blocking events and notifications out of AntiTrackingCommon.cpp; r=baku
https://hg.mozilla.org/integration/autoland/rev/2e0107047365
Part 3: Move MaybeGetDocumentURIBeingLoaded to AntiTrackingUtils; r=baku
https://hg.mozilla.org/integration/autoland/rev/4e3b61666d72
Part 4: Refactor the code for the redirect heuristic out of AntiTrackingCommon.cpp; r=baku
https://hg.mozilla.org/integration/autoland/rev/68e1a2f903d3
Part 5: Refactor the code for calculating the permission type string to AntiTrackingUtils; r=baku
https://hg.mozilla.org/integration/autoland/rev/3caedfb95834
Part 6: Refactor the code related to user interactions out of AntiTrackingCommon.cpp; r=baku
https://hg.mozilla.org/integration/autoland/rev/da1235d7cba8
Part 7: Move TemporaryAccessGrantObserver out of AntiTrackingCommon.cpp; r=baku
https://hg.mozilla.org/integration/autoland/rev/3634b502a4cf
Part 8: Rename AntiTrackingCommon to ContentBlocking; r=baku
https://hg.mozilla.org/integration/autoland/rev/3e6879bd461e
Part 9: Move ContentBlockingLog to antitracking to keep all related code together in the same place; r=baku

Comment 17

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/66b3bf7917f1
https://hg.mozilla.org/mozilla-central/rev/2e0107047365
https://hg.mozilla.org/mozilla-central/rev/4e3b61666d72
https://hg.mozilla.org/mozilla-central/rev/68e1a2f903d3
https://hg.mozilla.org/mozilla-central/rev/3caedfb95834
https://hg.mozilla.org/mozilla-central/rev/da1235d7cba8
https://hg.mozilla.org/mozilla-central/rev/3634b502a4cf
https://hg.mozilla.org/mozilla-central/rev/3e6879bd461e