Closed
Bug 1620352
Opened 5 years ago
Closed 5 years ago
Error icon and lock icon are very similar at a glance on the calendar list
Categories
(Calendar :: Calendar Frontend, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 75.0
People
(Reporter: clokep, Assigned: Paenglab)
Details
Attachments
(2 files, 1 obsolete file)
|
5.54 KB,
image/png
|
Details | |
|
1.29 KB,
patch
|
Paenglab
:
review+
|
Details | Diff | Splinter Review |
Lock & error icons
See the attached screenshot, it is really easy to confuse the lock and error icons.
aleca and paenglab seem to agree that the hole in the lock should be removed.
|
Assignee | |
Comment 1•5 years ago
|
||
This removes the lock icon's keyhole to better differentiate from the warn icon.
I think this is okay when Alessandro reviews this calendar patch because it's only a UI change.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9131220 -
Flags: review?(alessandro)
|
||
Comment 2•5 years ago
|
||
Comment on attachment 9131220 [details] [diff] [review]
1620352-locked-icon.patch
Review of attachment 9131220 [details] [diff] [review]:
-----------------------------------------------------------------
Perfect!
Can you update the commit message with:
"Bug 1620352 - Remove the keyhole from the lock icon to better differentiate it from the warning icon. r=aleca"
Attachment #9131220 -
Flags: review?(alessandro) → review+
|
|
Assignee | |
Comment 3•5 years ago
|
||
Attachment #9131220 -
Attachment is obsolete: true
Attachment #9131222 -
Flags: review+
|
|
Assignee | |
Updated•5 years ago
|
Keywords: checkin-needed-tb
|
||
Updated•5 years ago
|
Target Milestone: --- → 75
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/4f347e1ba230
Remove the keyhole from the lock icon to better differentiate it from the warning icon. r=aleca
You need to log in
before you can comment on or make changes to this bug.
Description
•