Closed Bug 1620404 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 22104 - Fix bounding box calculation for <tspan> (and other LayoutSVGInlines)

Categories

(Core :: SVG, task, P4)

Product:
Core
Component:
SVG
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla76
Tracking Flags:
Tracking Status
firefox76 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 22104 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/22104
Details from upstream follow.

Fredrik Söderquist <fs@opera.com> wrote:

Fix bounding box calculation for <tspan> (and other LayoutSVGInlines)

Make the various bounding box calculations for LayoutSVGInline return
values derived from the associated flow boxes rather than delegating
to the ancestor LayoutSVGText. Refactor and reuse the code from the
similar functionality LayoutSVGText.

Since the reference box for these element should still remain the same
as the reference box for the ancestor \<text> add a new helper to
compute (delegate) that and use that when resolving clips/filter/et.c.

Bug: 951706, 349835, 267481
Change-Id: Idf4a4c586ef9902cac2e795e9fbda0009b2ea0ad

Reviewed-on: https://chromium-review.googlesource.com/2088094
WPT-Export-Revision: 40dfd7864f5c5c7e47627c866176e719dcf8f6ad

Component: web-platform-tests → SVG
Product: Testing → Core

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 49 tests

Status Summary

Firefox

OK : 3
PASS: 21[GitHub] 67[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt]

Chrome

OK : 3
PASS: 18
FAIL: 3

Safari

OK : 3
PASS: 16
FAIL: 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1c6e80710624
[wpt PR 22104] - Fix bounding box calculation for <tspan> (and other LayoutSVGInlines), a=testonly

https://hg.mozilla.org/mozilla-central/rev/1c6e80710624

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox76: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.