1620495 - Remove the js::LazyScript type

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[Ted Campbell [:tcampbell]]

After Bug 1619803, we should remove all remaining uses of the js::LazyScript type. The remaining uses are primarily as a namespace for static methods, and as a type for method overload resolution.

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1620495 - Cleanup LazyScript overflow checks

The old limits were to due bit packing tricks of a very old form of the
LazyScript data structure. Replace this with a limit of UINT32_MAX. For
simplicity, just fail the parse if we hit this limit since the full parse
will also fail.

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: Bug 1620495 - Remove LazyScript::CreateForXDR

Replace with LazyScript::CreateRaw and move the custom initialization to
XDRLazySscript.

Depends on D66846

Comment 3

[Ted Campbell [:tcampbell]]

Attachment: Bug 1620495 - Remove type-overloads using LazyScript

Cleanup up code in the Debugger and in PublicIterators that only used the
LazyScript for overload resolution. This changes are largely mechanical and
there is room to improve implementations in future

Depends on D66847

Comment 4

[Ted Campbell [:tcampbell]]

Attachment: Bug 1620495 - Remove various uses of LazyScript

Remove miscelaneous uses of LazyScript type. Also move XDRScriptData from
LazyScript to BaseScript. Also remove JSFunction::lazyScript().

Depends on D66848

Comment 5

[Ted Campbell [:tcampbell]]

Attachment: Bug 1620495 - Move LazyScript creation methods to BaseScript

Move the methods to BaseScript and remove the LazyScript type entirely!

Depends on D66849

Comment 6

[Ted Campbell [:tcampbell]]

Patch stack removes the js::LazyScript type entirely. What remains is fixing up comments and filing follow-up bugs for optimizations and cleanups that are now possible.

Comment 7

[Ted Campbell [:tcampbell]]

Attachment: Bug 1620495 - Fix up header include references to LazyScript

Depends on D66850

Comment 8

[Ted Campbell [:tcampbell]]

Attachment: Bug 1620495 - Remove references to LazyScript in comments

Depends on D66875

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4478047b72de
Cleanup LazyScript overflow checks r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/c1233643f6af
Remove LazyScript::CreateForXDR r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/17f0784ab346
Remove type-overloads using LazyScript r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/1bf4fb5973f8
Remove various uses of LazyScript r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/40d56eb71cdd
Move LazyScript creation methods to BaseScript r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/3119be3dcf97
Fix up header include references to LazyScript r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/ac02488efbcc
Remove references to LazyScript in comments r=mgaudet

Comment 10

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/4478047b72de
https://hg.mozilla.org/mozilla-central/rev/c1233643f6af
https://hg.mozilla.org/mozilla-central/rev/17f0784ab346
https://hg.mozilla.org/mozilla-central/rev/1bf4fb5973f8
https://hg.mozilla.org/mozilla-central/rev/40d56eb71cdd
https://hg.mozilla.org/mozilla-central/rev/3119be3dcf97
https://hg.mozilla.org/mozilla-central/rev/ac02488efbcc