Remove the js::LazyScript type
Categories
(Core :: JavaScript Engine, task, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox76 | --- | fixed |
People
(Reporter: tcampbell, Assigned: tcampbell)
References
Details
Attachments
(7 files)
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review |
After Bug 1619803, we should remove all remaining uses of the js::LazyScript
type. The remaining uses are primarily as a namespace for static methods, and as a type for method overload resolution.
Assignee | ||
Comment 1•10 months ago
|
||
The old limits were to due bit packing tricks of a very old form of the
LazyScript data structure. Replace this with a limit of UINT32_MAX. For
simplicity, just fail the parse if we hit this limit since the full parse
will also fail.
Assignee | ||
Comment 2•10 months ago
|
||
Replace with LazyScript::CreateRaw and move the custom initialization to
XDRLazySscript.
Depends on D66846
Assignee | ||
Comment 3•10 months ago
|
||
Cleanup up code in the Debugger and in PublicIterators that only used the
LazyScript for overload resolution. This changes are largely mechanical and
there is room to improve implementations in future
Depends on D66847
Assignee | ||
Comment 4•10 months ago
|
||
Remove miscelaneous uses of LazyScript type. Also move XDRScriptData from
LazyScript to BaseScript. Also remove JSFunction::lazyScript().
Depends on D66848
Assignee | ||
Comment 5•10 months ago
|
||
Move the methods to BaseScript and remove the LazyScript type entirely!
Depends on D66849
Assignee | ||
Comment 6•10 months ago
|
||
Patch stack removes the js::LazyScript
type entirely. What remains is fixing up comments and filing follow-up bugs for optimizations and cleanups that are now possible.
Updated•10 months ago
|
Assignee | ||
Comment 7•10 months ago
|
||
Depends on D66850
Assignee | ||
Comment 8•10 months ago
|
||
Depends on D66875
Pushed by tcampbell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4478047b72de Cleanup LazyScript overflow checks r=mgaudet https://hg.mozilla.org/integration/autoland/rev/c1233643f6af Remove LazyScript::CreateForXDR r=mgaudet https://hg.mozilla.org/integration/autoland/rev/17f0784ab346 Remove type-overloads using LazyScript r=mgaudet https://hg.mozilla.org/integration/autoland/rev/1bf4fb5973f8 Remove various uses of LazyScript r=mgaudet https://hg.mozilla.org/integration/autoland/rev/40d56eb71cdd Move LazyScript creation methods to BaseScript r=mgaudet https://hg.mozilla.org/integration/autoland/rev/3119be3dcf97 Fix up header include references to LazyScript r=mgaudet https://hg.mozilla.org/integration/autoland/rev/ac02488efbcc Remove references to LazyScript in comments r=mgaudet
Comment 10•10 months ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4478047b72de
https://hg.mozilla.org/mozilla-central/rev/c1233643f6af
https://hg.mozilla.org/mozilla-central/rev/17f0784ab346
https://hg.mozilla.org/mozilla-central/rev/1bf4fb5973f8
https://hg.mozilla.org/mozilla-central/rev/40d56eb71cdd
https://hg.mozilla.org/mozilla-central/rev/3119be3dcf97
https://hg.mozilla.org/mozilla-central/rev/ac02488efbcc
Description
•