Closed Bug 1620522 Opened 4 years ago Closed 4 years ago

Perma [tier2] image/test/reftest/bmp/bmpsuite/q/rgb24prof.bmp == image/test/reftest/bmp/bmpsuite/q/rgb24.png | image comparison, max difference: 1, number of differing pixels: 73

Categories

(Core :: Graphics: ImageLib, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla77
Tracking Status
firefox76 --- fixed
firefox77 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: aosmond)

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell unknown])

Attachments

(1 file)

I see, it is possible the AArch / NEON implementation of premultiply and color management may have some slight rounding differences compared to x86 / SSE / AVX.

Summary: Intermittent image/test/reftest/bmp/bmpsuite/q/rgb24prof.bmp == image/test/reftest/bmp/bmpsuite/q/rgb24.png | image comparison, max difference: 1, number of differing pixels: 73 → Perma [tier2] image/test/reftest/bmp/bmpsuite/q/rgb24prof.bmp == image/test/reftest/bmp/bmpsuite/q/rgb24.png | image comparison, max difference: 1, number of differing pixels: 73

There are 24 total failures in the last 7 days on windows10-aarch64, opt build type.

Recent failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=293167714&repo=mozilla-central&lineNumber=18489

Andrew,
this failure start to be perma-tier2 on central, 6 days ago.

Flags: needinfo?(aosmond)

Andrew,
Should we disable this test till a solution is found?

Assignee: nobody → aosmond
Flags: needinfo?(aosmond)
Priority: -- → P3
Pushed by aosmond@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5b42abec66cf
Increase fuzz on BMP color managed reftest.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77

This is still occurring on beta, should the fix be uplifted?

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=298342452&repo=mozilla-beta&lineNumber=4688

Flags: needinfo?(aosmond)

Comment on attachment 9140113 [details]
Bug 1620522 - Increase fuzz on BMP color managed reftest.

Beta/Release Uplift Approval Request

  • User impact if declined: None
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Just increases the fuzz for a test that already has some.
  • String changes made/needed:
Flags: needinfo?(aosmond)
Attachment #9140113 - Flags: approval-mozilla-beta?

Comment on attachment 9140113 [details]
Bug 1620522 - Increase fuzz on BMP color managed reftest.

This can be uplifted a=test-only.

Attachment #9140113 - Flags: approval-mozilla-beta?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: