Closed Bug 1620598 Opened 6 years ago Closed 6 years ago

Replace BrowserTestUtils.waitForCondition with TestUtils.waitForCondition in browser/base/content/test/general/browser_bug581253.js

Categories

(Firefox :: General, task, P5)

Product:
Firefox
Component:
General
Type:
task

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1622244

People

(Reporter: prathiksha, Assigned: sabina.barbhuiya, Mentored)

Details

(Keywords: good-first-bug)

This is a good first bug for newcomers to Firefox development.

BrowserTestUtils.waitForCondition in browser/base/content/test/general/browser_bug581253.js[0] can be replaced by TestUtils.waitForCondition

You can run this test with the ./mach test command:
./mach test browser/base/content/test/general/browser_bug581253.js

Please leave a comment if you would like to be assigned to this bug. Feel free to contact us via Matrix in the #osfcep channel or leave a comment here if you're stuck.

[0] https://searchfox.org/mozilla-central/rev/13b081a62d3f3e3e3120f95564529257b0bf451c/browser/base/content/test/general/browser_bug581253.js#32

Hi pratiksha. Can you please assign this issue to me (as discussed over email)?

Assignee: nobody → sabina.barbhuiya
Status: NEW → ASSIGNED

Sabina, are you still looking into this? :)

Flags: needinfo?(sabina.barbhuiya)
Type: enhancement → task
Priority: -- → P5
Status: ASSIGNED → NEW
Flags: needinfo?(sabina.barbhuiya)
Keywords: good-first-bug

The file browser/base/content/test/general/browser_bug581253.js doesn't use "BrowserTestUtils.waitForCondition". If you could verify it in case I overlooked it. Thanks.

(In reply to Ratnabali Dutta from comment #3)

The file browser/base/content/test/general/browser_bug581253.js doesn't use "BrowserTestUtils.waitForCondition". If you could verify it in case I overlooked it. Thanks.

Oh, thanks for pointing this out. It looks like a duplicate of Bug 1622244 :)

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.