1620600 - Add flags to allow image decoders to produce sRGB output

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, enhancement, P3)

Description

[Andrew Osmond [:aosmond] (he/him)]

Currently we can only use the gfx.color_management.force_srgb to force all images to sRGB, or accept device space. Adding a surface flag which allows us to selectively output sRGB is useful for clipboard purposes, as well as testing.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1620600 - Add flags to allow image decoders to produce sRGB output.

Currently we can only use the gfx.color_management.force_srgb pref to
force all images to sRGB, or just accept device space. It would be nice
to be able to test device space in our tests, as well as sRGB. This
patch adds a surface flag which allows us to selectively output sRGB.

This will also be useful for clipboard and re-encoding purposes, since
they want a neutral output. In an ideal world we would just output the
color profile and the pixel data in the original color space, but for
now this is a relatively simple approach that works on all platforms and
interops well with all applications.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e6e5816403d9
Add flags to allow image decoders to produce sRGB output. r=tnikkel

Comment 3

[Arthur Iakab [arthur_iakab]]

Backed out changeset e6e5816403d9 (bug 1620600) for causing Gtest failures.

Backout revision https://hg.mozilla.org/integration/autoland/rev/c01bce3a4e0f7bd2c821a803da5c615e4b09c511

Failed push https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=292775199&searchStr=os%2Cx%2C10.14%2Cdebug%2Ctest-macosx1014-64%2Fdebug-gtest-1proc%2C%28gtest%29&revision=e6e5816403d958a0bcaf427195ca7b113263d01f

Failure logs https://treeherder.mozilla.org/logviewer.html#?job_id=292775199&repo=autoland

Andrew can you please take a look?

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:aosmond, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aae7f0d27d71
Add flags to allow image decoders to produce sRGB output. r=tnikkel

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/aae7f0d27d71