1620613 - Fission WebRender info bar appears with Fission enabled even if WebRender is enabled

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect, P1)

Description

[Andrew McCreight (out of office until 8/21) [:mccr8]]

My Windows 10 machine has WebRender enabled automatically, but the info bar is still showing up.

Comment 1

[Andrew McCreight (out of office until 8/21) [:mccr8]]

Yoric, could you please take a look? Let me know if you want more info about my Windows machine where I'm seeing this.

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Should be easy to fix, but I need to find what is measured incorrectly. @mcrr8, can you confirm the values of preferences:

• "gfx.webrender.all"
• ""fission.autostart"

and the following expressions?

Cc["@mozilla.org/gfx/info;1"].getService(Ci.nsIGfxInfo).WebRenderEnabled
gFissionBrowser                    // Not entirely sure how to best run this expression these days. You may need to patch browser.js with a `console.log`.
window.docShell.useRemoteSubframes // Not entirely sure how to best run this expression these days. You may need to patch browser.js with a `console.log`.

Comment 3

[Andrew McCreight (out of office until 8/21) [:mccr8]]

"gfx.webrender.all" is false, "fission.autostart" is true.

In about:support, Compositing is WebRender.

Cc["@mozilla.org/gfx/info;1"].getService(Ci.nsIGfxInfo).WebRenderEnabled is true. gFissionBrowser is undefined, at least when I'm running this in a console for about:support. window.docShell.useRemoteSubframes is true.

Comment 4

[:Gijs (he/him)]

Attachment: Bug 1620613 - improve checks for the webrender + fission infobar, r?Yoric

Comment 5

[:Gijs (he/him)]

(In reply to Andrew McCreight [:mccr8] from comment #3)

gFissionBrowser is undefined, at least when I'm running this in a console for about:support.

You'd need to run it from the browser console for it to have a value (ctrl-shift-j, you may need to enable input via the "browser and add-on debugging" checkbox in the options of the "normal" devtools).

Comment 6

[Chris Peterson [:cpeterson]]

Tracking for Fission's Dogfooding milestone (M5) because this WebRender warning is causing user confusion.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb07f7e084a1
improve checks for the webrender + fission infobar, r=Yoric

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/bb07f7e084a1