Closed Bug 162062 Opened 24 years ago Closed 24 years ago

[PATCH] [CRASH] Composer crashes when placing caret in a <head> displayed with CSS [@ nsHTMLEditor::GetCSSBackgroundColorState]

Categories

(SeaMonkey :: Composer, defect)

x86
Windows 2000
defect
Not set
critical

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: brian, Assigned: glazou)

Details

(Keywords: crash, testcase)

Crash Data

Attachments

(2 files)

If I add the following style: head, title, style { display: block; } to an HTML file, the contents of the title and style elements are displayed correctly in the browser, but in Composer, clicking inside one of them crashes. This used to not crash, but now it does. Back when it didn't crash, the caret wasn't allowed in the <head> element. Now in win32 build 2002080918 I can see that it is drawn there immediately before crashing. Perhaps that has something to do with it.
Attached file testcase —
Testcase. Open in Composer, and click anywhere above the last line. (Or use the arrow keys even)
Talkback ID's: TB9167967E TB9167264H TB9167164M TB9167020Y
Keywords: crash, patch
Keywords: patch → stackwanted, testcase
Whiteboard: [has TB ID]
Not a core problem: nsHTMLEditor::GetCSSBackgroundColorState [c:/builds/seamonkey/mozilla/editor/libeditor/html/nsHTMLEditor.cpp, line 2284] nsHTMLEditor::GetBackgroundColorState [c:/builds/seamonkey/mozilla/editor/libeditor/html/nsHTMLEditor.cpp, line 2186] nsBackgroundColorStateCommand::GetCurrentState [c:/builds/seamonkey/mozilla/editor/composer/src/nsComposerCommands.cpp, line 1450] nsMultiStateCommand::UpdateCommandState [c:/builds/seamonkey/mozilla/editor/composer/src/nsComposerCommands.cpp, line 1013] nsMultiStateCommand::IsCommandEnabled [c:/builds/seamonkey/mozilla/editor/composer/src/nsComposerCommands.cpp, line 949] nsControllerCommandManager::IsCommandEnabled [c:/builds/seamonkey/mozilla/embedding/components/commandhandler/src/nsControllerCommandManager.cpp, line 128] nsComposerController::IsCommandEnabled [c:/builds/seamonkey/mozilla/editor/composer/src/nsComposerController.cpp, line 227] XPTC_InvokeByIndex [c:/builds/seamonkey/mozilla/xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp, line 106] XPCWrappedNative::CallMethod [c:/builds/seamonkey/mozilla/js/src/xpconnect/src/xpcwrappednative.cpp, line 1996] XPC_WN_CallMethod [c:/builds/seamonkey/mozilla/js/src/xpconnect/src/xpcwrappednativejsops.cpp, line 1267] js_Invoke [c:/builds/seamonkey/mozilla/js/src/jsinterp.c, line 840] js_Interpret [c:/builds/seamonkey/mozilla/js/src/jsinterp.c, line 2792] js_Invoke [c:/builds/seamonkey/mozilla/js/src/jsinterp.c, line 856] js_InternalInvoke [c:/builds/seamonkey/mozilla/js/src/jsinterp.c, line 931] JS_CallFunctionValue [c:/builds/seamonkey/mozilla/js/src/jsapi.c, line 3433] nsJSContext::CallEventHandler [c:/builds/seamonkey/mozilla/dom/src/base/nsJSEnvironment.cpp, line 1044] nsJSEventListener::HandleEvent [c:/builds/seamonkey/mozilla/dom/src/events/nsJSEventListener.cpp, line 184] nsEventListenerManager::HandleEventSubType [c:/builds/seamonkey/mozilla/content/events/src/nsEventListenerManager.cpp, line 1183] nsEventListenerManager::HandleEvent [c:/builds/seamonkey/mozilla/content/events/src/nsEventListenerManager.cpp, line 2171] nsXULElement::HandleDOMEvent [c:/builds/seamonkey/mozilla/content/xul/content/src/nsXULElement.cpp, line 3453] nsXULCommandDispatcher::UpdateCommands [c:/builds/seamonkey/mozilla/content/xul/document/src/nsXULCommandDispatcher.cpp, line 391] GlobalWindowImpl::UpdateCommands [c:/builds/seamonkey/mozilla/dom/src/base/nsGlobalWindow.cpp, line 3176] nsInterfaceState::CallUpdateCommands [c:/builds/seamonkey/mozilla/editor/composer/src/nsInterfaceState.cpp, line 305] nsInterfaceState::TimerCallback [c:/builds/seamonkey/mozilla/editor/composer/src/nsInterfaceState.cpp, line 267] nsInterfaceState::Notify [c:/builds/seamonkey/mozilla/editor/composer/src/nsInterfaceState.cpp, line 339] nsTimerImpl::Fire [c:/builds/seamonkey/mozilla/xpcom/threads/nsTimerImpl.cpp, line 350] nsAppShell::Run [c:/builds/seamonkey/mozilla/widget/src/windows/nsAppShell.cpp, line 134] nsAppShellService::Run [c:/builds/seamonkey/mozilla/xpfe/appshell/src/nsAppShellService.cpp, line 452] main1 [c:/builds/seamonkey/mozilla/xpfe/bootstrap/nsAppRunner.cpp, line 1532] main [c:/builds/seamonkey/mozilla/xpfe/bootstrap/nsAppRunner.cpp, line 1883] WinMain [c:/builds/seamonkey/mozilla/xpfe/bootstrap/nsAppRunner.cpp, line 1901] WinMainCRTStartup() KERNEL32.DLL + 0x1ca90 (0x77e9ca90)
Assignee: kin → syd
Component: Editor: Core → Editor: Composer
Keywords: stackwanted
Whiteboard: [has TB ID]
Summary: Composer crashes when placing caret in a <head> displayed with CSS → Composer crashes when placing caret in a <head> displayed with CSS [@ nsHTMLEditor::GetCSSBackgroundColorState]
accepting
Status: NEW → ASSIGNED
Ah, given the test case, that's normal... nsHTMLEditor::NodeIsBlockStatic() was not considering HEAD as a block container and then nsHTMLEditor::GetBlockNodeParent() was climbing too far still looking for a block. Fix pending.
Joe or Kathy, can you r= please ? Kin, can you sr= please ?
Summary: Composer crashes when placing caret in a <head> displayed with CSS [@ nsHTMLEditor::GetCSSBackgroundColorState] → [PATCH] [CRASH] Composer crashes when placing caret in a <head> displayed with CSS [@ nsHTMLEditor::GetCSSBackgroundColorState]
Whiteboard: fix in hand, needs r=, needs sr=
reassigning to glazman
Assignee: syd → glazman
Status: ASSIGNED → NEW
Status: NEW → ASSIGNED
Comment on attachment 94906 [details] [diff] [review] patch v1.0, ready for reviews r=brade
Attachment #94906 - Flags: review+
Comment on attachment 94906 [details] [diff] [review] patch v1.0, ready for reviews sr=bzbarsky
Attachment #94906 - Flags: superreview+
checked in (trunk)
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Whiteboard: fix in hand, needs r=, needs sr=
This also occurs in the latest 1.0 branch build. Will the fix get checked in there, too?
Product: Browser → Seamonkey
Crash Signature: [@ nsHTMLEditor::GetCSSBackgroundColorState]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: