Closed
Bug 162062
Opened 24 years ago
Closed 24 years ago
[PATCH] [CRASH] Composer crashes when placing caret in a <head> displayed with CSS [@ nsHTMLEditor::GetCSSBackgroundColorState]
Categories
(SeaMonkey :: Composer, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: brian, Assigned: glazou)
Details
(Keywords: crash, testcase)
Crash Data
Attachments
(2 files)
|
471 bytes,
text/html
|
Details | |
|
2.58 KB,
patch
|
Brade
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
If I add the following style:
head, title, style { display: block; }
to an HTML file, the contents of the title and style elements are displayed
correctly in the browser, but in Composer, clicking inside one of them crashes.
This used to not crash, but now it does. Back when it didn't crash, the caret
wasn't allowed in the <head> element. Now in win32 build 2002080918 I can see
that it is drawn there immediately before crashing. Perhaps that has something
to do with it.
| Reporter | ||
Comment 1•24 years ago
|
||
Testcase. Open in Composer, and click anywhere above the last line. (Or use
the arrow keys even)
| Reporter | ||
Comment 2•24 years ago
|
||
Talkback ID's:
TB9167967E
TB9167264H
TB9167164M
TB9167020Y
Updated•24 years ago
|
Whiteboard: [has TB ID]
Comment 3•24 years ago
|
||
Not a core problem:
nsHTMLEditor::GetCSSBackgroundColorState
[c:/builds/seamonkey/mozilla/editor/libeditor/html/nsHTMLEditor.cpp, line 2284]
nsHTMLEditor::GetBackgroundColorState
[c:/builds/seamonkey/mozilla/editor/libeditor/html/nsHTMLEditor.cpp, line 2186]
nsBackgroundColorStateCommand::GetCurrentState
[c:/builds/seamonkey/mozilla/editor/composer/src/nsComposerCommands.cpp, line 1450]
nsMultiStateCommand::UpdateCommandState
[c:/builds/seamonkey/mozilla/editor/composer/src/nsComposerCommands.cpp, line 1013]
nsMultiStateCommand::IsCommandEnabled
[c:/builds/seamonkey/mozilla/editor/composer/src/nsComposerCommands.cpp, line 949]
nsControllerCommandManager::IsCommandEnabled
[c:/builds/seamonkey/mozilla/embedding/components/commandhandler/src/nsControllerCommandManager.cpp,
line 128]
nsComposerController::IsCommandEnabled
[c:/builds/seamonkey/mozilla/editor/composer/src/nsComposerController.cpp, line 227]
XPTC_InvokeByIndex
[c:/builds/seamonkey/mozilla/xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp,
line 106]
XPCWrappedNative::CallMethod
[c:/builds/seamonkey/mozilla/js/src/xpconnect/src/xpcwrappednative.cpp, line 1996]
XPC_WN_CallMethod
[c:/builds/seamonkey/mozilla/js/src/xpconnect/src/xpcwrappednativejsops.cpp,
line 1267]
js_Invoke [c:/builds/seamonkey/mozilla/js/src/jsinterp.c, line 840]
js_Interpret [c:/builds/seamonkey/mozilla/js/src/jsinterp.c, line 2792]
js_Invoke [c:/builds/seamonkey/mozilla/js/src/jsinterp.c, line 856]
js_InternalInvoke [c:/builds/seamonkey/mozilla/js/src/jsinterp.c, line 931]
JS_CallFunctionValue [c:/builds/seamonkey/mozilla/js/src/jsapi.c, line 3433]
nsJSContext::CallEventHandler
[c:/builds/seamonkey/mozilla/dom/src/base/nsJSEnvironment.cpp, line 1044]
nsJSEventListener::HandleEvent
[c:/builds/seamonkey/mozilla/dom/src/events/nsJSEventListener.cpp, line 184]
nsEventListenerManager::HandleEventSubType
[c:/builds/seamonkey/mozilla/content/events/src/nsEventListenerManager.cpp, line
1183]
nsEventListenerManager::HandleEvent
[c:/builds/seamonkey/mozilla/content/events/src/nsEventListenerManager.cpp, line
2171]
nsXULElement::HandleDOMEvent
[c:/builds/seamonkey/mozilla/content/xul/content/src/nsXULElement.cpp, line 3453]
nsXULCommandDispatcher::UpdateCommands
[c:/builds/seamonkey/mozilla/content/xul/document/src/nsXULCommandDispatcher.cpp,
line 391]
GlobalWindowImpl::UpdateCommands
[c:/builds/seamonkey/mozilla/dom/src/base/nsGlobalWindow.cpp, line 3176]
nsInterfaceState::CallUpdateCommands
[c:/builds/seamonkey/mozilla/editor/composer/src/nsInterfaceState.cpp, line 305]
nsInterfaceState::TimerCallback
[c:/builds/seamonkey/mozilla/editor/composer/src/nsInterfaceState.cpp, line 267]
nsInterfaceState::Notify
[c:/builds/seamonkey/mozilla/editor/composer/src/nsInterfaceState.cpp, line 339]
nsTimerImpl::Fire [c:/builds/seamonkey/mozilla/xpcom/threads/nsTimerImpl.cpp,
line 350]
nsAppShell::Run [c:/builds/seamonkey/mozilla/widget/src/windows/nsAppShell.cpp,
line 134]
nsAppShellService::Run
[c:/builds/seamonkey/mozilla/xpfe/appshell/src/nsAppShellService.cpp, line 452]
main1 [c:/builds/seamonkey/mozilla/xpfe/bootstrap/nsAppRunner.cpp, line 1532]
main [c:/builds/seamonkey/mozilla/xpfe/bootstrap/nsAppRunner.cpp, line 1883]
WinMain [c:/builds/seamonkey/mozilla/xpfe/bootstrap/nsAppRunner.cpp, line 1901]
WinMainCRTStartup()
KERNEL32.DLL + 0x1ca90 (0x77e9ca90)
Assignee: kin → syd
Component: Editor: Core → Editor: Composer
Updated•24 years ago
|
Keywords: stackwanted
Whiteboard: [has TB ID]
Summary: Composer crashes when placing caret in a <head> displayed with CSS → Composer crashes when placing caret in a <head> displayed with CSS [@ nsHTMLEditor::GetCSSBackgroundColorState]
| Assignee | ||
Comment 5•24 years ago
|
||
Ah, given the test case, that's normal... nsHTMLEditor::NodeIsBlockStatic()
was not considering HEAD as a block container and then
nsHTMLEditor::GetBlockNodeParent() was climbing too far still looking for a block.
Fix pending.
| Assignee | ||
Comment 6•24 years ago
|
||
| Assignee | ||
Comment 7•24 years ago
|
||
Joe or Kathy, can you r= please ?
Kin, can you sr= please ?
Summary: Composer crashes when placing caret in a <head> displayed with CSS [@ nsHTMLEditor::GetCSSBackgroundColorState] → [PATCH] [CRASH] Composer crashes when placing caret in a <head> displayed with CSS [@ nsHTMLEditor::GetCSSBackgroundColorState]
Whiteboard: fix in hand, needs r=, needs sr=
| Assignee | ||
Comment 8•24 years ago
|
||
reassigning to glazman
Assignee: syd → glazman
Status: ASSIGNED → NEW
| Assignee | ||
Updated•24 years ago
|
Status: NEW → ASSIGNED
Comment 9•24 years ago
|
||
Comment on attachment 94906 [details] [diff] [review]
patch v1.0, ready for reviews
r=brade
Attachment #94906 -
Flags: review+
Comment 10•24 years ago
|
||
Comment on attachment 94906 [details] [diff] [review]
patch v1.0, ready for reviews
sr=bzbarsky
Attachment #94906 -
Flags: superreview+
| Assignee | ||
Comment 11•24 years ago
|
||
checked in (trunk)
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Whiteboard: fix in hand, needs r=, needs sr=
| Reporter | ||
Comment 12•24 years ago
|
||
This also occurs in the latest 1.0 branch build. Will the fix get checked in
there, too?
Updated•21 years ago
|
Product: Browser → Seamonkey
Updated•15 years ago
|
Crash Signature: [@ nsHTMLEditor::GetCSSBackgroundColorState]
You need to log in
before you can comment on or make changes to this bug.
Description
•