1620641 - Replace BrowserTestUtils.waitForCondition with TestUtils.waitForCondition in browser_documentnavigation.js

Status: RESOLVED FIXED

(Firefox :: General, enhancement)

Description

[:prathiksha]

This is a good first bug for newcomers to Firefox development.

BrowserTestUtils.waitForCondition in browser/base/content/test/general/browser_documentnavigation.js[0] can be replaced by TestUtils.waitForCondition.

You can run this test with the ./mach test command:
./mach test browser/base/content/test/general/browser_documentnavigation.js

Please leave a comment if you would like to be assigned to this bug. Feel free to contact us via Matrix in the #osfcep channel or leave a comment here if you're stuck.

[0] https://searchfox.org/mozilla-central/rev/13b081a62d3f3e3e3120f95564529257b0bf451c/browser/base/content/test/general/browser_documentnavigation.js#495

Comment 1

[Sourab]

Hi, can I please work on this?

Comment 2

[Sourab]

Please let me know if I've understood this correct - This is a straight replacement of BrowserTestUtils module with TestUtils module because the waitForCondition method of BrowserTestUtils was just a reference to the same method defined in TestUtils.

Also, are these the right steps to take?

1. Make necessary changes
2. Make sure the tests run fine and eslint doesn't complain
3. Commit changes with an appropriate message
4. Then push code to Phabricator

Is there any additional steps I should take like making another clone or have a different branch or pull requests of some sorts?
Sorry for all these questions. This is my first encounter with Mercurial and I am yet to read the docs to know how different it is from Git.

Comment 3

[:prathiksha]

(In reply to skanthavar from comment #2)

Please let me know if I've understood this correct - This is a straight replacement of BrowserTestUtils module with TestUtils module because the waitForCondition method of BrowserTestUtils was just a reference to the same method defined in TestUtils.

Also, are these the right steps to take?

1. Make necessary changes
2. Make sure the tests run fine and eslint doesn't complain
3. Commit changes with an appropriate message
4. Then push code to Phabricator

Is there any additional steps I should take like making another clone or have a different branch or pull requests of some sorts?
Sorry for all these questions. This is my first encounter with Mercurial and I am yet to read the docs to know how different it is from Git.

Yes, you have understood it correctly. Please just follow all the steps you just listed. There are no additional steps required. I am assuming that you have cloned the 'mozilla-central' repo using 'hg clone' and followed all setup instructions from our document.

Comment 4

[Sourab]

Attachment: Bug 1620641 - Replace waitForCondition method of BrowserTestUtils with TestUtils'. r=prathiksha

Comment 5

[Sourab]

Attachment: Bug 1620641 - Replace BrowserTestUtils.waitForCondition with TestUtils.waitForCondition in browser_documentnavigation.js. r=prathiksha

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3893a9b0514c
Replace BrowserTestUtils.waitForCondition with TestUtils.waitForCondition in browser_documentnavigation.js. r=prathiksha

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/3893a9b0514c