Closed Bug 1620641 Opened 1 year ago Closed 1 year ago

Replace BrowserTestUtils.waitForCondition with TestUtils.waitForCondition in browser_documentnavigation.js

Categories

(Firefox :: General, enhancement)

Product:
Firefox
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 75
Tracking Flags:
Tracking Status
firefox75 --- fixed

People

(Reporter: prathiksha, Assigned: skanthavar, Mentored)

Details

Attachments

(1 file, 1 obsolete file)

Bug 1620641 - Replace BrowserTestUtils.waitForCondition with TestUtils.waitForCondition in browser_documentnavigation.js. r=prathiksha
47 bytes, text/x-phabricator-request
Details | Review

This is a good first bug for newcomers to Firefox development.

BrowserTestUtils.waitForCondition in browser/base/content/test/general/browser_documentnavigation.js[0] can be replaced by TestUtils.waitForCondition.

You can run this test with the ./mach test command:
./mach test browser/base/content/test/general/browser_documentnavigation.js

Please leave a comment if you would like to be assigned to this bug. Feel free to contact us via Matrix in the #osfcep channel or leave a comment here if you're stuck.

[0] https://searchfox.org/mozilla-central/rev/13b081a62d3f3e3e3120f95564529257b0bf451c/browser/base/content/test/general/browser_documentnavigation.js#495

Hi, can I please work on this?

Assignee: nobody → skanthavar
Status: NEW → ASSIGNED

Please let me know if I've understood this correct - This is a straight replacement of BrowserTestUtils module with TestUtils module because the waitForCondition method of BrowserTestUtils was just a reference to the same method defined in TestUtils.

Also, are these the right steps to take?

  1. Make necessary changes
  2. Make sure the tests run fine and eslint doesn't complain
  3. Commit changes with an appropriate message
  4. Then push code to Phabricator

Is there any additional steps I should take like making another clone or have a different branch or pull requests of some sorts?
Sorry for all these questions. This is my first encounter with Mercurial and I am yet to read the docs to know how different it is from Git.

(In reply to skanthavar from comment #2)

Please let me know if I've understood this correct - This is a straight replacement of BrowserTestUtils module with TestUtils module because the waitForCondition method of BrowserTestUtils was just a reference to the same method defined in TestUtils.

Also, are these the right steps to take?

  1. Make necessary changes
  2. Make sure the tests run fine and eslint doesn't complain
  3. Commit changes with an appropriate message
  4. Then push code to Phabricator

Is there any additional steps I should take like making another clone or have a different branch or pull requests of some sorts?
Sorry for all these questions. This is my first encounter with Mercurial and I am yet to read the docs to know how different it is from Git.

Yes, you have understood it correctly. Please just follow all the steps you just listed. There are no additional steps required. I am assuming that you have cloned the 'mozilla-central' repo using 'hg clone' and followed all setup instructions from our document.

Attachment #9131595 - Attachment is obsolete: true
Pushed by prathikshaprasadsuman@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3893a9b0514c
Replace BrowserTestUtils.waitForCondition with TestUtils.waitForCondition in browser_documentnavigation.js. r=prathiksha

https://hg.mozilla.org/mozilla-central/rev/3893a9b0514c

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox75: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 75
You need to log in before you can comment on or make changes to this bug.