Closed Bug 1620646 Opened 4 years ago Closed 4 years ago

Fix mixed `' ticks in "debuggee would run" warning

Categories

(Core :: JavaScript Engine, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: Harald, Assigned: soniasingla)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

Summary: Fix mixed `' ticks in debuggee would run warning → Fix mixed `' ticks in "debuggee would run" warning

FWIW, this is also present in JSMSG_DEBUG_OPTIMIZED_OUT, JSMSG_DEBUG_CANT_SET_OPT_ENV, JSMSG_UNINITIALIZED_LEXICAL, JSMSG_BAD_CONST_ASSIGN, and JSMSG_CANT_DECLARE_GLOBAL_BINDING.

Can i take this issue? :)

Thanks
Sonia

Sonia, yes please!

Flags: needinfo?(soniasingla.1812)
Priority: -- → P1
Priority: P1 → P2
Flags: needinfo?(soniasingla.1812)
Assignee: nobody → soniasingla.1812
Status: NEW → ASSIGNED
Pushed by btara@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ae7594e8509c
Fix mixed `' ticks in "debuggee would run" warning. r=jorendorff
Flags: needinfo?(soniasingla.1812)

Hi Andrei

Can you please provide follow up? Am not sure why it failed :/

Flags: needinfo?(aciure)

Hi,
I'm a code sheriff, I can't provide a fix for this.

Jason can you take a look?

Flags: needinfo?(aciure) → needinfo?(jorendorff)

Sonia,

I clicked the "log: ..." link in comment 6, and found out that these tests were failing. (Several of them fail multiple times, because we run some tests many times with slightly different options.)

Each one is failing because it checks the exact error message. It's OK to just change all the tests to expect the new message.

js/src/jit-test/tests/debug/Object-forceLexicalInitializationByName.js
js/src/jit-test/tests/debug/optimized-out-03.js
js/src/jit-test/tests/debug/optimized-out-arrow-this.js
js/src/jit-test/tests/parser/redeclaration-message.js
js/src/tests/non262/extensions/regress-465443.js
js/src/tests/non262/regress/regress-452498-112.js

Flags: needinfo?(jorendorff) → needinfo?(soniasingla.1812)
Attachment #9144992 - Attachment description: Bug 1620646 - Fix mixed `' ticks in "debuggee would run" warning. r=jorendorff → Bug 1620646 - Changes updated for test failure. r=jorendorff
Flags: needinfo?(soniasingla.1812)
Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c3090a952a79
Changes updated for test failure. r=jorendorff
Attachment #9144992 - Attachment description: Bug 1620646 - Changes updated for test failure. r=jorendorff → Bug 1620646 - Changes fixed for test failure. r=jorendorff
Flags: needinfo?(soniasingla.1812)
Pushed by jorendorff@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1f11ec544f47
Changes fixed for test failure. r=jorendorff
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: