Fix mixed `' ticks in "debuggee would run" warning
Categories
(Core :: JavaScript Engine, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox78 | --- | fixed |
People
(Reporter: Harald, Assigned: soniasingla)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
Mixed use of ` and ' in
https://searchfox.org/mozilla-central/rev/13b081a62d3f3e3e3120f95564529257b0bf451c/js/src/js.msg#516
debuggee `{0}:{1}' would run
Reporter | ||
Updated•4 years ago
|
Comment 1•4 years ago
|
||
FWIW, this is also present in JSMSG_DEBUG_OPTIMIZED_OUT
, JSMSG_DEBUG_CANT_SET_OPT_ENV
, JSMSG_UNINITIALIZED_LEXICAL
, JSMSG_BAD_CONST_ASSIGN
, and JSMSG_CANT_DECLARE_GLOBAL_BINDING
.
Assignee | ||
Comment 2•4 years ago
|
||
Can i take this issue? :)
Thanks
Sonia
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 4•4 years ago
|
||
Updated•4 years ago
|
Pushed by btara@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ae7594e8509c Fix mixed `' ticks in "debuggee would run" warning. r=jorendorff
Comment 6•4 years ago
|
||
Backed out changeset ae7594e8509c (bug 1620646) for causing SM bustages
https://hg.mozilla.org/integration/autoland/rev/c568436ce79559dd1b022289805773d386038455
push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=busted%2Cexception&revision=ae7594e8509cfc2c8bf98608717eac8139a3161e
log: https://treeherder.mozilla.org/logviewer.html#?job_id=300423614&repo=autoland
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 7•4 years ago
|
||
Hi Andrei
Can you please provide follow up? Am not sure why it failed :/
Comment 8•4 years ago
|
||
Hi,
I'm a code sheriff, I can't provide a fix for this.
Jason can you take a look?
Comment 9•4 years ago
|
||
Sonia,
I clicked the "log: ..." link in comment 6, and found out that these tests were failing. (Several of them fail multiple times, because we run some tests many times with slightly different options.)
Each one is failing because it checks the exact error message. It's OK to just change all the tests to expect the new message.
js/src/jit-test/tests/debug/Object-forceLexicalInitializationByName.js
js/src/jit-test/tests/debug/optimized-out-03.js
js/src/jit-test/tests/debug/optimized-out-arrow-this.js
js/src/jit-test/tests/parser/redeclaration-message.js
js/src/tests/non262/extensions/regress-465443.js
js/src/tests/non262/regress/regress-452498-112.js
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Comment 10•4 years ago
|
||
Pushed by nbeleuzu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c3090a952a79 Changes updated for test failure. r=jorendorff
Comment 11•4 years ago
|
||
Backed out changeset c3090a952a79 (Bug 1620646) for sm bustages at regress-465443.js.
https://hg.mozilla.org/integration/autoland/rev/6b0cb1cc06c4ef10f4f3475a1926edd2bd740022
Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=300571226&repo=autoland&lineNumber=48275
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Comment 12•4 years ago
|
||
Pushed by jorendorff@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1f11ec544f47 Changes fixed for test failure. r=jorendorff
Comment 13•4 years ago
|
||
bugherder |
Description
•