1620705 - Don't send "memory-pressure" if ContentChild::mShuttingDown

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, task, P1)

Description

[Andrew McCreight [:mccr8]]

Olli suggested this. I added code to do this for GC/CC in bug 1620623, because we already have a boolean notification, but it looks like there's other stuff we do on memory pressure.

Comment 1

[Gabriele Svelto [:gsvelto]]

This is a very meaningful optimization: one of the things we do when we hit a low-memory condition is to shut down the preallocated process so we don't want to make that slow by having it respond to a memory-pressure event. Additionally if/when we re-enable tab unloading we might start shutting down other content processes too in response to memory-pressure events.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Bug 1620705 - Don't send "memory-pressure" if ContentChild::mShuttingDown.

Shutting down the process is going to free more memory than anything else we
could do, so don't delay it.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5481f3606f3b
Don't send "memory-pressure" if ContentChild::mShuttingDown. r=smaug

Comment 4

[Chris Peterson [:cpeterson]]

P1

Comment 5

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/5481f3606f3b