Closed Bug 1620728 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 22127 - Cleanup min max

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla76
Tracking Flags:
Tracking Status
firefox76 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 22127 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/22127
Details from upstream follow.

Tab Atkins-Bittner <jackalmage@gmail.com> wrote:

Cleanup min max

  • Continued fixup of numeric-testcommon.js for greater general applicability
  • Added serialization-testcommon.js to make testing serialization simpler and clearer.
  • Fixed all the min()/max() tests to use one of the above support libraries, in a consistent manner.
  • Made all the min()/max() serialization tests match the current spec.
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 63 tests

Status Summary

Firefox

OK : 14
PASS : 432[GitHub] 478[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]
FAIL : 57

Chrome

OK : 14
PASS : 367
FAIL : 122

Safari

OK : 13
PASS : 322
CRASH: 1
FAIL : 116

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-values/minmax-length-percent-computed.html
calc(min(1.5em, 10%) - max(1em, 15%)) should be used-value-equivalent to -30px: FAIL

New Tests That Don't Pass

/css/css-values/minmax-percentage-serialize.html
'max(1%, 2%, 3%)' as a computed value should serialize as 'max(1%, 2%, 3%)'.: FAIL (Chrome: FAIL, Safari: FAIL)
'min(3%, 2%, 1%)' as a specified value should serialize as 'min(3%, 2%, 1%)'.: FAIL (Chrome: PASS, Safari: FAIL)
'max(3%, 2%, 1%)' as a specified value should serialize as 'max(3%, 2%, 1%)'.: FAIL (Chrome: PASS, Safari: FAIL)
'min(1%, 2%, 3%)' as a computed value should serialize as 'min(1%, 2%, 3%)'.: FAIL (Chrome: FAIL, Safari: FAIL)
'min(1%, 2%, 3%)' as a specified value should serialize as 'min(1%, 2%, 3%)'.: FAIL (Chrome: PASS, Safari: FAIL)
'max(3%, 2%, 1%)' as a computed value should serialize as 'max(3%, 2%, 1%)'.: FAIL (Chrome: FAIL, Safari: FAIL)
'min(3%, 2%, 1%)' as a computed value should serialize as 'min(3%, 2%, 1%)'.: FAIL (Chrome: FAIL, Safari: FAIL)
'max(1%, 2%, 3%)' as a specified value should serialize as 'max(1%, 2%, 3%)'.: FAIL (Chrome: PASS, Safari: FAIL)
'min(1%, 2%, 3%) 0px' as a specified value should serialize as 'min(1%, 2%, 3%) 0px'.: FAIL (Chrome: PASS, Safari: FAIL)
'min(1%, 2%, 3%) 0px' as a computed value should serialize as 'min(1%, 2%, 3%) 0px'.: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-values/round-function.html
round(15px, -10px) should be used-value-equivalent to 20px: FAIL (Chrome: FAIL, Safari: FAIL)
round(nearest, 15px, 10px) should be used-value-equivalent to 20px: FAIL (Chrome: FAIL, Safari: FAIL)
round(nearest, 13px, 10px) should be used-value-equivalent to 10px: FAIL (Chrome: FAIL, Safari: FAIL)
round(down, 18px, 10px) should be used-value-equivalent to 10px: FAIL (Chrome: FAIL, Safari: FAIL)
round(-18px, 10px) should be used-value-equivalent to -20px: FAIL (Chrome: FAIL, Safari: FAIL)
round(up, 18px, 10px) should be used-value-equivalent to 20px: FAIL (Chrome: FAIL, Safari: FAIL)
round(15px, 10px) should be used-value-equivalent to 20px: FAIL (Chrome: FAIL, Safari: FAIL)
round(down, 13px, 10px) should be used-value-equivalent to 10px: FAIL (Chrome: FAIL, Safari: FAIL)
round(23px, 10px) should be used-value-equivalent to 20px: FAIL (Chrome: FAIL, Safari: FAIL)
round(13px, 10px) should be used-value-equivalent to 10px: FAIL (Chrome: FAIL, Safari: FAIL)
round(down, -13px, 10px) should be used-value-equivalent to -20px: FAIL (Chrome: FAIL, Safari: FAIL)
round(13px, -10px) should be used-value-equivalent to 10px: FAIL (Chrome: FAIL, Safari: FAIL)
round(to-zero, 23px, 10px) should be used-value-equivalent to 20px: FAIL (Chrome: FAIL, Safari: FAIL)
round(down, 15px, 10px) should be used-value-equivalent to 10px: FAIL (Chrome: FAIL, Safari: FAIL)
round(up, -13px, 10px) should be used-value-equivalent to -10px: FAIL (Chrome: FAIL, Safari: FAIL)
round(to-zero, 13px, 10px) should be used-value-equivalent to 10px: FAIL (Chrome: FAIL, Safari: FAIL)
round(down, -18px, 10px) should be used-value-equivalent to -20px: FAIL (Chrome: FAIL, Safari: FAIL)
round(up, -18px, 10px) should be used-value-equivalent to -10px: FAIL (Chrome: FAIL, Safari: FAIL)
round(to-zero, -13px, 10px) should be used-value-equivalent to -10px: FAIL (Chrome: FAIL, Safari: FAIL)
round(18px, -10px) should be used-value-equivalent to 20px: FAIL (Chrome: FAIL, Safari: FAIL)
round(18px, 10px) should be used-value-equivalent to 20px: FAIL (Chrome: FAIL, Safari: FAIL)
round(up, 15px, 10px) should be used-value-equivalent to 20px: FAIL (Chrome: FAIL, Safari: FAIL)
round(23px, -10px) should be used-value-equivalent to 20px: FAIL (Chrome: FAIL, Safari: FAIL)
round(nearest, 23px, 10px) should be used-value-equivalent to 20px: FAIL (Chrome: FAIL, Safari: FAIL)
round(up, 13px, 10px) should be used-value-equivalent to 20px: FAIL (Chrome: FAIL, Safari: FAIL)
round(nearest, -18px, 10px) should be used-value-equivalent to -20px: FAIL (Chrome: FAIL, Safari: FAIL)
round(down, 23px, 10px) should be used-value-equivalent to 20px: FAIL (Chrome: FAIL, Safari: FAIL)
round(-13px, 10px) should be used-value-equivalent to -10px: FAIL (Chrome: FAIL, Safari: FAIL)
round(nearest, 18px, 10px) should be used-value-equivalent to 20px: FAIL (Chrome: FAIL, Safari: FAIL)
round(to-zero, 18px, 10px) should be used-value-equivalent to 10px: FAIL (Chrome: FAIL, Safari: FAIL)
round(-13px, -10px) should be used-value-equivalent to -10px: FAIL (Chrome: FAIL, Safari: FAIL)
round(to-zero, 15px, 10px) should be used-value-equivalent to 10px: FAIL (Chrome: FAIL, Safari: FAIL)
round(nearest, -13px, 10px) should be used-value-equivalent to -10px: FAIL (Chrome: FAIL, Safari: FAIL)
round(-18px, -10px) should be used-value-equivalent to -20px: FAIL (Chrome: FAIL, Safari: FAIL)
round(up, 23px, 10px) should be used-value-equivalent to 30px: FAIL (Chrome: FAIL, Safari: FAIL)
round(to-zero, -18px, 10px) should be used-value-equivalent to -10px: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-values/minmax-length-percent-computed.html
calc(min(1.5em, 10%) - max(1em, 15%)) should be used-value-equivalent to -30px: FAIL (Chrome: PASS, Safari: PASS)
/css/css-values/minmax-length-percent-serialize.html
'min(1% + 1px)' as a computed value should serialize as 'min(1% + 1px)'.: FAIL (Chrome: PASS)
'calc(min(10% + 1px) + max(1em + 10%) + min(10% + 20px))' as a computed value should serialize as 'calc(min(10% + 1px) + max(10% + 16px) + min(10% + 20px))'.: FAIL (Chrome: PASS)
'max(1px + 1%)' as a specified value should serialize as 'max(1% + 1px)'.: FAIL (Chrome: FAIL)
'calc(1em + max(10% + 20px) + 5% + min(1em + 10%) + 10px)' as a computed value should serialize as 'calc(5% + 26px + max(10% + 20px) + min(10% + 16px))'.: FAIL (Chrome: FAIL)
'max(1px + 1%)' as a computed value should serialize as 'max(1% + 1px)'.: FAIL (Chrome: PASS)
'min(1% + 1px)' as a specified value should serialize as 'min(1% + 1px)'.: FAIL (Chrome: PASS)
'calc(min(10% + 1px) + max(1em + 10%) + min(10% + 20px))' as a specified value should serialize as 'calc(min(10% + 1px) + max(10% + 1em) + min(10% + 20px))'.: FAIL (Chrome: FAIL)
'min(1px + 1%)' as a specified value should serialize as 'min(1% + 1px)'.: FAIL (Chrome: FAIL)
'min(1px + 1%)' as a computed value should serialize as 'min(1% + 1px)'.: FAIL (Chrome: PASS)
'calc(1em + max(10% + 20px) + 5% + min(1em + 10%) + 10px)' as a specified value should serialize as 'calc(5% + 1em + 10px + max(10% + 20px) + min(10% + 1em))'.: FAIL (Chrome: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/25004bf6cb29
[wpt PR 22127] - Cleanup min max, a=testonly
https://hg.mozilla.org/integration/autoland/rev/0c2493cb1527
[wpt PR 22127] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/25004bf6cb29
https://hg.mozilla.org/mozilla-central/rev/0c2493cb1527

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox76: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.