Open Bug 1620739 Opened 8 months ago Updated 5 months ago

Graphs View - TableView and GraphTooltip component share helpers functions

Categories

(Tree Management :: Perfherder, task, P3)

Tracking

(Not tracked)

People

(Reporter: yonashiro.mellina, Unassigned, Mentored)

Details

There are some functions/instructions which can be moved to helpers.js to be shared between TableView and GraphTooltip components.

The function can be seen in:

Priority: -- → P3

Hi Mellina, thanks for reporting this. I could be mistaken, but I don't see any shared code or functions between these two files. Could you show me what you're referring to?

Flags: needinfo?(yonashiro.mellina)
Mentor: ksereduck

Oh I remembered that I was frustrated I couldn't choose an interval of lines to be highlighted in Github. I've marked the related snippets:

https://github.com/mozilla/treeherder/blob/master/ui/perfherder/graphs/TableView.jsx
22-32: delta values
35-55: push and jobs url

https://github.com/mozilla/treeherder/blob/master/ui/perfherder/graphs/GraphTooltip.jsx
47-55: delta values
76-90:push and jobs url

I would like to solve this too, if I'm allowed.

Flags: needinfo?(yonashiro.mellina)
You need to log in before you can comment on or make changes to this bug.