Graphs View - TableView and GraphTooltip component share helpers functions
Categories
(Tree Management :: Perfherder, task, P3)
Tracking
(Not tracked)
People
(Reporter: yonashiro.mellina, Unassigned, Mentored)
Details
There are some functions/instructions which can be moved to helpers.js to be shared between TableView and GraphTooltip components.
The function can be seen in:
|
||
Updated•5 years ago
|
|
||
Comment 1•5 years ago
|
||
Hi Mellina, thanks for reporting this. I could be mistaken, but I don't see any shared code or functions between these two files. Could you show me what you're referring to?
|
|
||
Updated•5 years ago
|
|
Reporter | |
Comment 2•5 years ago
|
||
Oh I remembered that I was frustrated I couldn't choose an interval of lines to be highlighted in Github. I've marked the related snippets:
https://github.com/mozilla/treeherder/blob/master/ui/perfherder/graphs/TableView.jsx
22-32: delta values
35-55: push and jobs url
https://github.com/mozilla/treeherder/blob/master/ui/perfherder/graphs/GraphTooltip.jsx
47-55: delta values
76-90:push and jobs url
I would like to solve this too, if I'm allowed.
Description
•