Closed Bug 1620744 Opened 1 year ago Closed 1 year ago

Convert manual py_action's in Makefiles to py3_action

Categories

(Firefox Build System :: General, task, P3)

task

Tracking

(firefox76 fixed)

RESOLVED FIXED
mozilla76
Tracking Status
firefox76 --- fixed

People

(Reporter: mshal, Assigned: mshal)

References

Details

Attachments

(14 files)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review

There's a bunch of py_action calls in Makefiles, which also need to be converted to py3_action. Plus a few py2=True lines that I missed.

Pushed by mshal@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6e4d85b19f88
Use py3_action for cases that already support it; r=firefox-build-system-reviewers,rstewart
https://hg.mozilla.org/integration/autoland/rev/78e78f7c7b26
Convert process_define_files.py to py3; r=firefox-build-system-reviewers,rstewart
https://hg.mozilla.org/integration/autoland/rev/6d597d2eb792
Convert generate_symbols_file.py to py3; r=firefox-build-system-reviewers,rstewart
https://hg.mozilla.org/integration/autoland/rev/2fa34749bbfa
Convert fat_aar.py to py3; r=nalexander
https://hg.mozilla.org/integration/autoland/rev/0997313a9f99
Convert variables.py:source_repo_header() to py3; r=firefox-build-system-reviewers,rstewart
https://hg.mozilla.org/integration/autoland/rev/3372c9ab721c
Convert prepare_tlds.py to py3; r=firefox-build-system-reviewers,rstewart
https://hg.mozilla.org/integration/autoland/rev/622a2f7414fa
Convert gen_dll_blocklist_defs.py to py3; r=firefox-build-system-reviewers,rstewart
https://hg.mozilla.org/integration/autoland/rev/1de09de1a802
Convert generated_sources.py to py3; r=firefox-build-system-reviewers,rstewart
https://hg.mozilla.org/integration/autoland/rev/8e95b21b2ae3
Convert generate_mapfile.py to py3; r=firefox-build-system-reviewers,rstewart
https://hg.mozilla.org/integration/autoland/rev/3bc8fda68107
Convert check_binary.py to py3; r=firefox-build-system-reviewers,rstewart
https://hg.mozilla.org/integration/autoland/rev/b8faa0184d4f
Convert dumpsymbols.py to py3; r=firefox-build-system-reviewers,rstewart
https://hg.mozilla.org/integration/autoland/rev/a1e97f0b91ef
Convert jar_maker action to py3; r=firefox-build-system-reviewers,rstewart
https://hg.mozilla.org/integration/autoland/rev/6beda54bcb9b
Convert test_archive action to py3; r=firefox-build-system-reviewers,rstewart
Backout by dvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ba409a89fb2b
Backed out 13 changesets for causing diffoscope failures firefox/browser/chrome/browser/content/browser/built_in_addons.json

Backed out 13 changesets (Bug 1620744) for causing diffoscope failures firefox/browser/chrome/browser/content/browser/built_in_addons.json

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&collapsedPushes=659858&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=6beda54bcb9b9c7e29c9ddbddd93052d9d30387a

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=292523122&repo=autoland&lineNumber=7045

Backout link: https://treeherder.mozilla.org/#/jobs?repo=autoland&collapsedPushes=659858&searchStr=dwe&revision=ba409a89fb2bceefbd93f25c32d759cfc1aea9d7

[task 2020-03-10T18:19:40.594Z] + curl -L -f https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/M4riZmrHQXeME7xzSWQHQQ/artifacts/public/build/target.generated-files.tar.gz
[task 2020-03-10T18:19:40.600Z]   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
[task 2020-03-10T18:19:40.600Z]                                  Dload  Upload   Total   Spent    Left  Speed
[task 2020-03-10T18:19:40.600Z] 
[task 2020-03-10T18:19:40.689Z]   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
[task 2020-03-10T18:19:40.689Z]   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
[task 2020-03-10T18:19:40.689Z] curl: (22) The requested URL returned error: 404 
[task 2020-03-10T18:19:40.690Z] + HAVE_GENERATED_FILES=
[task 2020-03-10T18:19:40.690Z] + test -z ''
[task 2020-03-10T18:19:40.690Z] + report_error diff
[task 2020-03-10T18:19:40.690Z] + python3
[task 2020-03-10T18:19:40.700Z] TEST-UNEXPECTED-FAIL | firefox/browser/chrome/browser/content/browser/built_in_addons.json differs. See the diff.html or diff.txt artifact
[task 2020-03-10T18:19:40.702Z] + fail
[task 2020-03-10T18:19:40.702Z] + exit 1
[taskcluster 2020-03-10 18:19:43.750Z] === Task Finished ===
[taskcluster 2020-03-10 18:19:43.964Z] Artifact "public/generated-files.diff.txt" not found at "/builds/worker/generated-files.diff.txt"
[taskcluster 2020-03-10 18:19:44.068Z] Artifact "public/generated-files.diff.html" not found at "/builds/worker/generated-files.diff.html"
[taskcluster 2020-03-10 18:19:44.333Z] Unsuccessful task run with exit code: 1 completed in 54.85 seconds
Flags: needinfo?(mshal)

The built_in_addons issue should be fixed by sorting the json.dump in gen_built_in_addons.py, and the test-verify failures are fixed by using io.open in layout/tools/reftest/reftest/init.py to ensure it is still py2 compatible.

Flags: needinfo?(mshal)
Pushed by mshal@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/34e5684eb645
Use py3_action for cases that already support it; r=firefox-build-system-reviewers,rstewart
https://hg.mozilla.org/integration/autoland/rev/067bb59b595a
Convert process_define_files.py to py3; r=firefox-build-system-reviewers,rstewart
https://hg.mozilla.org/integration/autoland/rev/644ddba7ead7
Convert generate_symbols_file.py to py3; r=firefox-build-system-reviewers,rstewart
https://hg.mozilla.org/integration/autoland/rev/281486a0a103
Convert fat_aar.py to py3; r=nalexander
https://hg.mozilla.org/integration/autoland/rev/9dd0bba882db
Convert variables.py:source_repo_header() to py3; r=firefox-build-system-reviewers,rstewart
https://hg.mozilla.org/integration/autoland/rev/67cf4d23e6cd
Convert prepare_tlds.py to py3; r=firefox-build-system-reviewers,rstewart
https://hg.mozilla.org/integration/autoland/rev/54493f743e05
Convert gen_dll_blocklist_defs.py to py3; r=firefox-build-system-reviewers,rstewart
https://hg.mozilla.org/integration/autoland/rev/50eb60ded1cf
Convert generated_sources.py to py3; r=firefox-build-system-reviewers,rstewart
https://hg.mozilla.org/integration/autoland/rev/d16d24c9e00e
Convert generate_mapfile.py to py3; r=firefox-build-system-reviewers,rstewart
https://hg.mozilla.org/integration/autoland/rev/1968cc9fb447
Convert check_binary.py to py3; r=firefox-build-system-reviewers,rstewart
https://hg.mozilla.org/integration/autoland/rev/76e50388651e
Convert dumpsymbols.py to py3; r=firefox-build-system-reviewers,rstewart
https://hg.mozilla.org/integration/autoland/rev/0347d87d51b4
Convert jar_maker action to py3; r=firefox-build-system-reviewers,rstewart
https://hg.mozilla.org/integration/autoland/rev/b825720b0124
Convert test_archive action to py3; r=firefox-build-system-reviewers,rstewart
https://hg.mozilla.org/integration/autoland/rev/cad040db602c
Convert gen_built_in_addons.py to py3; r=firefox-build-system-reviewers,rstewart
Regressions: 1621753
Regressed by: 1622168
You need to log in before you can comment on or make changes to this bug.