Closed Bug 1620757 Opened 4 years ago Closed 4 years ago

Container "show this container" doesn't restore file:// tabs.

Categories

(WebExtensions :: Untriaged, defect)

73 Branch
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED MOVED

People

(Reporter: greg.brown.00, Unassigned)

References

(Blocks 1 open bug)

Details

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:73.0) Gecko/20100101 Firefox/73.0

Steps to reproduce:

Create a new container.
Open a new file tab in the container (file:///home/greg in my case).
Open another normal tab in the container (https://bugzilla.mozilla.org).
Click "Hide this container".
Then click "Show this container".

Actual results:

The container did not restore the file:// tab. It does restore the https:// tab.

In the list of tabs for the container, it shows the https tab as both shown and hidden and the file tab as hidden only.

You can try to "show this container" again.

Expected results:

Both tabs are restored.

Each tab only appears once in the list of container tabs and both should be visible.

The button changes back to "hide this container".

Hi,
I can reproduce this issue on my machine win 10 on Firefox Release 74, Firefox Beta 75 and Nightly 76 with Firefox Multi Account Containers enabled and steps mentioned above. I will set the component: Firefox Tabbed Browser, if it's not the right one please feel free to change it,
Thank you!

Status: UNCONFIRMED → NEW
Ever confirmed: true

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: Untriaged → Tabbed Browser

The priority flag is not set for this bug.
:dao, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(dao+bmo)
Component: Tabbed Browser → Security
Flags: needinfo?(dao+bmo)
Product: Firefox → Core

Seems like this has to do with permissions - the hide/show logic is implemented in the extension, and it'll be using the tab APIs to hide/show tabs. Zombie, why would hiding/showing the file: tabs not work?

Component: Security → Untriaged
Flags: needinfo?(tomica)
Product: Core → WebExtensions

It looks like instead of showing/hiding tabs, it actually closes and opens them:
https://github.com/mozilla/multi-account-containers/blob/d654810d/src/js/background/backgroundLogic.js#L315

Unfortunately, we prevent extensions from opening file:// urls for security reasons, we only support limited interactions with local files that users explicitly open themselves.

Flags: needinfo?(tomica)

I filed https://github.com/mozilla/multi-account-containers/issues/1717 for this on the add-on's github repo.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → MOVED
You need to log in before you can comment on or make changes to this bug.