Closed Bug 1620802 Opened 5 years ago Closed 5 years ago

Replace BrowserTestUtils.waitForCondition with TestUtils.waitForCondition in browser_captivePortalTabReference.js

Categories

(Firefox :: General, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 76
Tracking Status
firefox76 --- fixed

People

(Reporter: prathiksha, Assigned: aarushivij, Mentored)

Details

Attachments

(1 file)

This is a good first bug for newcomers to Firefox development.

BrowserTestUtils.waitForCondition in browser_captivePortalTabReference.js[0] can be replaced by TestUtils.waitForCondition.

You can run this test with the ./mach test command:
./mach test browser/base/content/test/captivePortal/browser_captivePortalTabReference.js

Please leave a comment if you would like to be assigned to this bug. Feel free to contact us via Matrix in the #osfcep channel or leave a comment here if you're stuck.

[0] https://searchfox.org/mozilla-central/rev/5a52cec97c41ae1eda9412dfe6f4099a9af4c7dd/browser/base/content/test/captivePortal/browser_captivePortalTabReference.js#83

Hello,
Can this issue be assigned to me?
Shall be my first contribution as an outreachy applicant :)
Aarushi

Assignee: nobody → aarushivij
Status: NEW → ASSIGNED
Pushed by prathikshaprasadsuman@gmail.com: https://hg.mozilla.org/integration/autoland/rev/d1dae117a730 Replace BrowserTestUtils.waitForCondition with TestUtils.waitForCondition in browser_captivePortalTabReference.js r=prathiksha
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 76
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: