1620936 - diffoscope tasks always contain failure line: TypeError: hilite() got an unexpected keyword argument 'ok'

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Since bug 1620513 landed, diffoscope tasks always contain the line TypeError: hilite() got an unexpected keyword argument 'ok' which gets detected by Treeherder as an issue due to the TypeError. This will confuse if the Diffoscope task actually fails.

Push: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=8eb13ba05ae5e87be9a2a579298bc6abfd17096b&tochange=04709da169a54345c5add8a6068431a4e60eaa46&fromchange=4922ebe168cc7eea69e73d5dbc48293c8ff0a780&selectedJob=292062628

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Mike Hommey [:glandium]]

The root cause is a bug in psutil. Filed https://github.com/giampaolo/psutil/issues/1714.

Comment 3

[Mike Hommey [:glandium]]

We can, however, workaround the message on our end.

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1620936 - Avoid creating a virtualenv when running unpack for diffoscope.

Creating the virtualenv prints an error message in the diffoscope docker
image because it doesn't have a compiler or the python development
headers, and that triggers an error setting up psutil after bug 1620513,
which in turn leads to a noisy and unrelated error message appearing in
the diffoscope jobs when they fail.

We don't need psutil set up really in those jobs, let alone a full
fledged virtualenv, so we can avoid the psutil error message by
disabling the virtualenv.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0dfbd1b0d2df
Avoid creating a virtualenv when running unpack for diffoscope. r=froydnj

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/0dfbd1b0d2df

Comment 7

[Julien Cristau [:jcristau]]

AFAIK we don't run diffoscope on beta.