Closed
Bug 1620952
Opened 5 years ago
Closed 5 years ago
Merge `nsFrameSelection`'s constructor and its `Init` method
Categories
(Core :: DOM: Selection, enhancement)
Core
DOM: Selection
Tracking
()
RESOLVED
FIXED
mozilla76
Tracking | Status | |
---|---|---|
firefox76 | --- | fixed |
People
(Reporter: mbrodesser-Igalia, Assigned: mbrodesser-Igalia)
References
(Blocks 1 open bug)
Details
Attachments
(9 files)
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review |
No description provided.
Assignee | ||
Comment 1•5 years ago
|
||
Might allow to merge its constructor and its Init
method.
Assignee | ||
Comment 2•5 years ago
|
||
Will allow to declare some members const.
Depends on D65953
Assignee | ||
Comment 3•5 years ago
|
||
Simplifies analyzing and further refactoring nsFrameSelection
.
Depends on D65954
Assignee | ||
Comment 4•5 years ago
|
||
Depends on D65957
Assignee | ||
Comment 5•5 years ago
|
||
Depends on D65959
Assignee | ||
Comment 6•5 years ago
|
||
Depends on D65960
Assignee | ||
Comment 7•5 years ago
|
||
Depends on D65961
Assignee | ||
Comment 8•5 years ago
|
||
The new name is clearer.
Depends on D66059
Assignee | ||
Comment 9•5 years ago
|
||
Depends on D66060
Assignee | ||
Updated•5 years ago
|
Keywords: leave-open
Comment 10•5 years ago
|
||
Pushed by mbrodesser@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/96bd9af83029
part 1) Construct `nsFrameSelection` as late as possible. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/b550d651df6d
part 2) Remove `nsFrameSelection::Init`. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/5ed69b726d14
part 3) Group delayed mouse event members in `nsFrameSelection`. r=jfkthame
Comment 11•5 years ago
|
||
Pushed by mbrodesser@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e59931951810
part 4) Group caret members in `nsFrameSelection`. r=jfkthame
Comment 12•5 years ago
|
||
bugherder |
Comment 13•5 years ago
|
||
bugherder |
Comment 14•5 years ago
|
||
Pushed by mbrodesser@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/539e7ef94446
part 5) Group limiter members in `nsFrameSelection`. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/3205728297e3
part 6) Group `mDesiredPos` and `mDesiredPosSet`. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/d2d182489323
part 7) Group batching members. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/3127ea7cec4d
part 8) Rename `nsFrameSelection::IsDirty`. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/a1d045de7bc4
part 9) Rename `nsFrameSelection::GetBatching` to `IsBatching`. r=jfkthame
Assignee | ||
Updated•5 years ago
|
Keywords: leave-open
Comment 15•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/539e7ef94446
https://hg.mozilla.org/mozilla-central/rev/3205728297e3
https://hg.mozilla.org/mozilla-central/rev/d2d182489323
https://hg.mozilla.org/mozilla-central/rev/3127ea7cec4d
https://hg.mozilla.org/mozilla-central/rev/a1d045de7bc4
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox76:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in
before you can comment on or make changes to this bug.
Description
•