Closed Bug 1620952 Opened 5 years ago Closed 5 years ago

Merge `nsFrameSelection`'s constructor and its `Init` method

Categories

(Core :: DOM: Selection, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla76
Tracking Status
firefox76 --- fixed

People

(Reporter: mbrodesser-Igalia, Assigned: mbrodesser-Igalia)

References

(Blocks 1 open bug)

Details

Attachments

(9 files)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
No description provided.

Might allow to merge its constructor and its Init method.

Will allow to declare some members const.

Depends on D65953

Simplifies analyzing and further refactoring nsFrameSelection.

Depends on D65954

Blocks: 1590379

The new name is clearer.

Depends on D66059

Keywords: leave-open
Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/96bd9af83029 part 1) Construct `nsFrameSelection` as late as possible. r=jfkthame https://hg.mozilla.org/integration/autoland/rev/b550d651df6d part 2) Remove `nsFrameSelection::Init`. r=jfkthame https://hg.mozilla.org/integration/autoland/rev/5ed69b726d14 part 3) Group delayed mouse event members in `nsFrameSelection`. r=jfkthame
Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e59931951810 part 4) Group caret members in `nsFrameSelection`. r=jfkthame
Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/539e7ef94446 part 5) Group limiter members in `nsFrameSelection`. r=jfkthame https://hg.mozilla.org/integration/autoland/rev/3205728297e3 part 6) Group `mDesiredPos` and `mDesiredPosSet`. r=jfkthame https://hg.mozilla.org/integration/autoland/rev/d2d182489323 part 7) Group batching members. r=jfkthame https://hg.mozilla.org/integration/autoland/rev/3127ea7cec4d part 8) Rename `nsFrameSelection::IsDirty`. r=jfkthame https://hg.mozilla.org/integration/autoland/rev/a1d045de7bc4 part 9) Rename `nsFrameSelection::GetBatching` to `IsBatching`. r=jfkthame
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: