Closed Bug 1620966 Opened 1 year ago Closed 10 months ago

Move DocShell.watchedByDevtools from DocShell up to BrowsingContext

Categories

(Core :: DOM: Navigation, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla78
Fission Milestone M6a
Tracking Status
firefox78 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

(Blocks 1 open bug)

Details

(Whiteboard: dt-fission-m2-mvp)

Attachments

(1 file, 1 obsolete file)

This attribute is currently on the DocShell:
https://searchfox.org/mozilla-central/source/docshell/base/nsIDocShell.idl#1113
But this forces us to manually apply this attribute in each individual remote iframe:
https://searchfox.org/mozilla-central/source/devtools/server/actors/targets/browsing-context.js#1564
https://searchfox.org/mozilla-central/source/devtools/server/actors/targets/browsing-context.js#781

It would be easier to move this flag up to the BrowsingContext class, so that it is replicated to the whole BrowsingContext tree, and even for remoted iframes.
In addition, it would help bug 1593937 reuse this BrowsingContext attribute in order to start loading DevTools code in the content processes.

Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: dt-fission-m2-mvp

Tracking Fission DevTools bugs for Fission Nightly (M6) milestone

Fission Milestone: --- → M6
Component: DOM: Core & HTML → DOM: Navigation

Tentatively moving P1 Fission M6 bugs to M6a.

Fission Milestone: M6 → M6a
Attachment #9140981 - Attachment is obsolete: true
Blocks: 1631443
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2b7abe98c721
Move DocShell.watchedByDevtools to BrowsingContext and rename it to watchedByDevTools. r=nika,jdescottes
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
Regressions: 1638914
You need to log in before you can comment on or make changes to this bug.