1620966 - Move DocShell.watchedByDevtools from DocShell up to BrowsingContext

Status: RESOLVED FIXED

(Core :: DOM: Navigation, enhancement, P1)

Description

[Alexandre Poirot [:ochameau]]

This attribute is currently on the DocShell:
https://searchfox.org/mozilla-central/source/docshell/base/nsIDocShell.idl#1113
But this forces us to manually apply this attribute in each individual remote iframe:
https://searchfox.org/mozilla-central/source/devtools/server/actors/targets/browsing-context.js#1564
https://searchfox.org/mozilla-central/source/devtools/server/actors/targets/browsing-context.js#781

It would be easier to move this flag up to the BrowsingContext class, so that it is replicated to the whole BrowsingContext tree, and even for remoted iframes.
In addition, it would help bug 1593937 reuse this BrowsingContext attribute in order to start loading DevTools code in the content processes.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1620966 - Move DocShell.watchedByDevtools to BrowsingContext and rename it to watchedByDevTools.

Comment 2

[Chris Peterson [:cpeterson]]

Tracking Fission DevTools bugs for Fission Nightly (M6) milestone

Comment 3

[Chris Peterson [:cpeterson]]

Tentatively moving P1 Fission M6 bugs to M6a.

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1620966 - Move DocShell.watchedByDevtools to BrowsingContext and rename it to watchedByDevTools.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b7abe98c721
Move DocShell.watchedByDevtools to BrowsingContext and rename it to watchedByDevTools. r=nika,jdescottes

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/2b7abe98c721