1621051 - Make nsIOService::AllowPort thread-safe

Status: RESOLVED FIXED

(Core :: Networking, task, P1)

Description

[Kershaw Chang [:kershaw]]

nsIOService::AllowPort is called from TRRServiceChannel::AsyncOpen, so we have to make it thread-safe.

Comment 1

[Kershaw Chang [:kershaw]]

Attachment: Bug 1621051 - Add a mutext to protect mRestrictedPortList,r?valentin

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2be4c9a3f053
Add a mutext to protect mRestrictedPortList,r=valentin

Comment 3

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/2be4c9a3f053

Comment 4

[Kershaw Chang [:kershaw]]

Comment on attachment 9132023 [details]
Bug 1621051 - Add a mutext to protect mRestrictedPortList,r?valentin

Beta/Release Uplift Approval Request

• User impact if declined: There could be a race when checking if a port is allowed to connect.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patch is quite simple and straightforward, so the risk is low.
• String changes made/needed: N/A

Comment 5

[Julien Cristau [:jcristau]]

Comment on attachment 9132023 [details]
Bug 1621051 - Add a mutext to protect mRestrictedPortList,r?valentin

approved for 75.0b2

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/releases/mozilla-beta/rev/95e774585014

Comment 7

[Masatoshi Kimura [:emk]]

What happens if nsIOService::AllowPort is called between restrictedPortList.Assign(mRestrictedPortList); and mRestrictedPortList.Assign(std::move(restrictedPortList));?