1621083 - improve the flatpak manifest

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, enhancement)

Description

[Mihai Tabara [:mtabara]⌚️GMT]

We used bug 1591387 to track the building of the flatpak in try staging releases. Starting bug 1591387 comment 15, some suggestions have been made about improving the flatpak manifest in order to obtain a more robust outcome.

I'm filing this bug to track all those conversations here, so that we let 1591387 serve its original purpose.

Comment 1

[Mihai Tabara [:mtabara]⌚️GMT]

Users have started testing the Flatpak beta that we published to the beta channel. Dropping here some more context from Matrix:

@ahayzen[m]: hey, i just tried the Firefox beta flatpak, it looks great ! The only thing so farthat didn't work straight away was being able to access the camera/microphone - i had to add --device=all to the permissions. Maybe this is because i have older portals? (Debian Stable) Or is portal / pipewire support not ready in Firefox yet ?

@barthalion: I think it's also needed for U2F to work (when udev rules are present on the host system), so I'd add it nonetheless

Comment 2

[Mihai Tabara [:mtabara]⌚️GMT]

@barthalion provided me a diff with some l10n fixes (see bug 1621074) - I'll take into account the --device=all config too, either here in a separate patch or there.

Comment 3

[Mihai Tabara [:mtabara]⌚️GMT]

Attachment: Bug 1621083 - open more ports for Flatpak. r=rail DONTBUILD

Comment 4

[Mihai Tabara [:mtabara]⌚️GMT]

Comment on attachment 9132342 [details]
Bug 1621083 - open more ports for Flatpak. r=rail DONTBUILD

Beta/Release Uplift Approval Request

• User impact if declined: None, this fixes configuration under the hood in building flatpaks
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1591387
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Releng automation change.
• String changes made/needed:

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5b3cd4209ae
open more ports for Flatpak. r=rail DONTBUILD

Comment 6

[Mihai Tabara [:mtabara]⌚️GMT]

Latest staging release pushed to beta channel so latest Flatpak on Flathub should have this fix.

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 9132342 [details]
Bug 1621083 - open more ports for Flatpak. r=rail DONTBUILD

approved for 75.0b3

Comment 8

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/e5b3cd4209ae

Comment 9

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e834dc5827a4

Comment 10

[Mihai Tabara [:mtabara]⌚️GMT]

Just to clarify, if we want to make more manifest improvements, let's reopen this bug. Until then, I'll keep it closed.

Comment 11

[jakob.jakobson13]

Could you please reopen this issue due to the following issue?

If you are installing firefox you currently get no hint (at least not on flathub.org or in Gnome software 3.36 ) that ffmpeg is listed in the manifest as an extension.
If you however use add-extensions instead of extension for the ffmpeg extension that would (at least in Gnome software and I have to admit that I don't fully understand how you create your flatpak package) result in a checkbox where the user can choose individually to install the ffmepg package. An example package for this approach would be Gnome games.

Comment 12

[jakob.jakobson13]

(In reply to jakob.jakobson13 from comment #11)

If you however use add-extensions instead of extension for the ffmpeg extension that would (at least in Gnome software and I have to admit that I don't fully understand how you create your flatpak package) result in a checkbox where the user can choose individually to install the ffmepg package. An example package for this approach would be Gnome games.

Okay, my solution is probably not the way to go. But if you could use a checkbox in gnome software to give the user the possibility to install ffmpeg, that would be neat.

Comment 13

[Mihai Tabara [:mtabara]⌚️GMT]

I'd check in with @barthalion for that, to be honest, he helped me polish the patches from this bug and has a deeper understanding on how that works. Either NI here or poke in #flatpaks in Matrix.