1621173 - Intermittent browser/base/content/test/general/browser_bug724239.js | about:newtab was added to the session history when AS was enabled. - Got false, expected true

Status: RESOLVED FIXED

(Firefox :: General, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: cbrindusan [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=292363062&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/DzgHP5prTLO5X-Q5NIvYdQ/runs/0/artifacts/public/logs/live_backing.log

---

[task 2020-03-09T23:27:59.654Z] 23:27:59 INFO - TEST-START | browser/base/content/test/general/browser_bug724239.js
[task 2020-03-09T23:27:59.655Z] 23:27:59 INFO - GECKO(1760) | [Child 1772: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x11bd3e800 == 2 [pid = 1772] [id = {0e24e1f1-10cc-ac4c-bf44-6f739186eba7}]
[task 2020-03-09T23:27:59.655Z] 23:27:59 INFO - GECKO(1760) | [Child 1772: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 13 (0x14287a260) [pid = 1772] [serial = 160] [outer = 0x0]
[task 2020-03-09T23:27:59.655Z] 23:27:59 INFO - GECKO(1760) | [Child 1772: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 14 (0x11bd71000) [pid = 1772] [serial = 161] [outer = 0x14287a260]
[task 2020-03-09T23:27:59.655Z] 23:27:59 INFO - GECKO(1760) | [Child 1772: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 15 (0x11bdef400) [pid = 1772] [serial = 162] [outer = 0x14287a260]
[task 2020-03-09T23:27:59.655Z] 23:27:59 INFO - GECKO(1760) | [Parent 1760: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x12106b000 == 31 [pid = 1760] [id = {851ec10b-31c5-4541-8b0b-29f682620764}] [url = chrome://mozapps/content/downloads/unknownContentType.xhtml]
[task 2020-03-09T23:27:59.656Z] 23:27:59 INFO - GECKO(1760) | [Child 1772: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 16 (0x144180400) [pid = 1772] [serial = 163] [outer = 0x14287a260]
[task 2020-03-09T23:27:59.656Z] 23:27:59 INFO - GECKO(1760) | [Child 1763: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x109643000 == 3 [pid = 1763] [id = {aeef7698-8541-2041-a3bf-fb530a1c0475}]
[task 2020-03-09T23:27:59.656Z] 23:27:59 INFO - GECKO(1760) | [Child 1763: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 6 (0x1349cf520) [pid = 1763] [serial = 138] [outer = 0x0]
[task 2020-03-09T23:27:59.656Z] 23:27:59 INFO - GECKO(1760) | [Child 1763: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 7 (0x114a13400) [pid = 1763] [serial = 139] [outer = 0x1349cf520]
[task 2020-03-09T23:27:59.656Z] 23:27:59 INFO - GECKO(1760) | [Child 1763: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 8 (0x122a63800) [pid = 1763] [serial = 140] [outer = 0x1349cf520]
[task 2020-03-09T23:27:59.666Z] 23:27:59 INFO - GECKO(1760) | [Parent 1760, Main Thread] WARNING: Wrong button set to eContextMenu event?: 'mMessage != eContextMenu || mButton == ((mContextMenuTrigger == eNormal) ? MouseButton::eRight : MouseButton::eLeft)', file /builds/worker/workspace/obj-build/dist/include/mozilla/MouseEvents.h, line 240
[task 2020-03-09T23:27:59.666Z] 23:27:59 INFO - GECKO(1760) | [Parent 1760: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x11ff9c800 == 30 [pid = 1760] [id = {e5d5cadf-75fa-da4a-8ee5-f7dd7ebf19ed}] [url = chrome://mozapps/content/downloads/unknownContentType.xhtml]
[task 2020-03-09T23:27:59.666Z] 23:27:59 INFO - GECKO(1760) | [Parent 1760: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x120b68000 == 29 [pid = 1760] [id = {fefb0cee-0c9e-ed47-bb4a-9cb972b84014}] [url = chrome://mozapps/content/downloads/unknownContentType.xhtml]
[task 2020-03-09T23:27:59.666Z] 23:27:59 INFO - GECKO(1760) | [Parent 1760: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x10e67f000 == 28 [pid = 1760] [id = {30539a77-3511-ca47-933d-2de347edc5e4}] [url = chrome://mozapps/content/downloads/unknownContentType.xhtml]
[task 2020-03-09T23:27:59.666Z] 23:27:59 INFO - GECKO(1760) | [Parent 1760: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x130410800 == 27 [pid = 1760] [id = {51cb1112-be57-f640-8b45-dec2cb51937d}] [url = chrome://mozapps/content/downloads/unknownContentType.xhtml]
[task 2020-03-09T23:27:59.666Z] 23:27:59 INFO - GECKO(1760) | [Parent 1760: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x121069800 == 26 [pid = 1760] [id = {56f2eb98-5106-a140-a5e0-13c71570a227}] [url = chrome://mozapps/content/downloads/unknownContentType.xhtml]
[task 2020-03-09T23:27:59.666Z] 23:27:59 INFO - GECKO(1760) | [Parent 1760: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x130d43000 == 25 [pid = 1760] [id = {1d33572d-2f41-4b4d-907d-fb4e0d9771fc}] [url = chrome://mozapps/content/downloads/unknownContentType.xhtml]
[task 2020-03-09T23:27:59.667Z] 23:27:59 INFO - GECKO(1760) | [Parent 1760: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x12cd2e800 == 24 [pid = 1760] [id = {bf19d537-e1fd-8949-aca0-d8fb8150d502}] [url = chrome://mozapps/content/downloads/unknownContentType.xhtml]
[task 2020-03-09T23:27:59.667Z] 23:27:59 INFO - GECKO(1760) | [Parent 1760: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x1322a7800 == 23 [pid = 1760] [id = {0aa84a10-0fb5-4947-a3d8-c4477eeb9e61}] [url = chrome://browser/content/browser.xhtml]
[task 2020-03-09T23:27:59.667Z] 23:27:59 INFO - GECKO(1760) | [Parent 1760: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 63 (0x134a0cc00) [pid = 1760] [serial = 98] [outer = 0x0] [url = about:logo]
[task 2020-03-09T23:27:59.667Z] 23:27:59 INFO - GECKO(1760) | [Parent 1760: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 62 (0x16276dc00) [pid = 1760] [serial = 102] [outer = 0x0] [url = about:blank]
[task 2020-03-09T23:27:59.667Z] 23:27:59 INFO - GECKO(1760) | [Parent 1760: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x130e7f800 == 22 [pid = 1760] [id = {ac11b51f-df1f-904f-92eb-36445388f2fc}] [url = chrome://mozapps/content/downloads/unknownContentType.xhtml]
[task 2020-03-09T23:27:59.667Z] 23:27:59 INFO - GECKO(1760) | [Parent 1760: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x1320ac800 == 21 [pid = 1760] [id = {aff3a764-a31d-4b42-a498-1eaf422ba6f6}] [url = chrome://mozapps/content/downloads/unknownContentType.xhtml]
[task 2020-03-09T23:27:59.667Z] 23:27:59 INFO - GECKO(1760) | [Child 1763: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x10963b800 == 2 [pid = 1763] [id = {33535b81-4b32-ab42-98e7-76ae5040a1b1}] [url = about:blank]
[task 2020-03-09T23:27:59.667Z] 23:27:59 INFO - GECKO(1760) | [Child 1763: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x122a22800 == 1 [pid = 1763] [id = {9579ba25-1c38-9d4c-a82b-ae976a0bbe42}] [url = about:blank]
[task 2020-03-09T23:27:59.668Z] 23:27:59 INFO - GECKO(1760) | [Child 1763: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 7 (0x1349cf6f0) [pid = 1763] [serial = 133] [outer = 0x0] [url = about:blank]
[task 2020-03-09T23:27:59.668Z] 23:27:59 INFO - GECKO(1760) | Waiting for browser load of about:newtab
[task 2020-03-09T23:27:59.668Z] 23:27:59 INFO - GECKO(1760) | [Child 1771: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x11d33d800 == 2 [pid = 1771] [id = {80186411-61b9-cf41-9936-1f168bd8cbef}]
[task 2020-03-09T23:27:59.668Z] 23:27:59 INFO - GECKO(1760) | [Child 1771: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 3 (0x10410b8c0) [pid = 1771] [serial = 18] [outer = 0x0]
[task 2020-03-09T23:27:59.668Z] 23:27:59 INFO - GECKO(1760) | [Child 1771: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 4 (0x11d548000) [pid = 1771] [serial = 19] [outer = 0x10410b8c0][task 2020-03-09T23:27:59.668Z] 23:27:59 INFO - GECKO(1760) | [Child 1771: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 5 (0x11dc2e800) [pid = 1771] [serial = 20] [outer = 0x10410b8c0]
[task 2020-03-09T23:27:59.668Z] 23:27:59 INFO - GECKO(1760) | Saw state c0010 and status 804b0002
[task 2020-03-09T23:27:59.669Z] 23:27:59 INFO - GECKO(1760) | Saw state f0001 and status 0
[task 2020-03-09T23:27:59.669Z] 23:27:59 INFO - GECKO(1760) | [Child 1771: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 6 (0x11dc36000) [pid = 1771] [serial = 21] [outer = 0x10410b8c0]
[task 2020-03-09T23:27:59.669Z] 23:27:59 INFO - GECKO(1760) | Saw state 110001 and status 0
[task 2020-03-09T23:27:59.669Z] 23:27:59 INFO - GECKO(1760) | Saw state c0010 and status 0
[task 2020-03-09T23:27:59.669Z] 23:27:59 INFO - GECKO(1760) | Browser loaded about:newtab
[task 2020-03-09T23:27:59.669Z] 23:27:59 INFO - GECKO(1760) | Waiting for browser load
[task 2020-03-09T23:27:59.669Z] 23:27:59 INFO - GECKO(1760) | Saw state f0001 and status 0
[task 2020-03-09T23:27:59.670Z] 23:27:59 INFO - GECKO(1760) | [Child 1771, Main Thread] WARNING: NS_ENSURE_TRUE(request) failed: file /builds/worker/checkouts/gecko/netwerk/base/nsLoadGroup.cpp, line 584
[task 2020-03-09T23:27:59.670Z] 23:27:59 INFO - GECKO(1760) | [Child 1763: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x109642000 == 2 [pid = 1763] [id = {1c4950e4-3e24-2042-afc8-a0261010bb9b}]
[task 2020-03-09T23:27:59.670Z] 23:27:59 INFO - GECKO(1760) | [Child 1763: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 8 (0x1349cf6f0) [pid = 1763] [serial = 141] [outer = 0x0]
[task 2020-03-09T23:27:59.670Z] 23:27:59 INFO - GECKO(1760) | [Child 1763: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 9 (0x1229a0400) [pid = 1763] [serial = 142] [outer = 0x1349cf6f0]
[task 2020-03-09T23:27:59.670Z] 23:27:59 INFO - GECKO(1760) | [Child 1763: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 10 (0x146410000) [pid = 1763] [serial = 143] [outer = 0x1349cf6f0]
[task 2020-03-09T23:27:59.670Z] 23:27:59 INFO - GECKO(1760) | Saw state c0010 and status 0
[task 2020-03-09T23:27:59.670Z] 23:27:59 INFO - GECKO(1760) | Browser loaded about:blank
[task 2020-03-09T23:27:59.670Z] 23:27:59 INFO - TEST-INFO | started process screencapture
[task 2020-03-09T23:27:59.804Z] 23:27:59 INFO - TEST-INFO | screencapture: exit 0
[task 2020-03-09T23:27:59.804Z] 23:27:59 INFO - Buffered messages logged at 23:27:38
[task 2020-03-09T23:27:59.805Z] 23:27:59 INFO - Entering test bound test_blank
[task 2020-03-09T23:27:59.805Z] 23:27:59 INFO - TEST-PASS | browser/base/content/test/general/browser_bug724239.js | about:blank wasn't added to session history -
[task 2020-03-09T23:27:59.805Z] 23:27:59 INFO - Buffered messages logged at 23:27:39
[task 2020-03-09T23:27:59.805Z] 23:27:59 INFO - Leaving test bound test_blank
[task 2020-03-09T23:27:59.806Z] 23:27:59 INFO - Entering test bound test_newtab
[task 2020-03-09T23:27:59.806Z] 23:27:59 INFO - Buffered messages finished
[task 2020-03-09T23:27:59.806Z] 23:27:59 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_bug724239.js | about:newtab was added to the session history when AS was enabled. - Got false, expected true

Comment 1

[Daniel Varga [:dvarga]]

Started retriggers: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=292614358&searchStr=OS%2CX%2C10.14%2Cdebug%2CMochitests%2Ctest-macosx1014-64%2Fdebug-mochitest-browser-chrome-e10s-11%2CM%28bc11%29&tochange=9448002ebec9e44bbb16c7d71760125093f0c3d0&fromchange=2b7446e9eca4672ba4a8cd3744837a45701551e6

I think it might be https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=OS%2CX%2C10.14%2Cdebug%2CMochitests%2Ctest-macosx1014-64%2Fdebug-mochitest-browser-chrome-e10s-11%2CM%28bc11%29&tochange=06ca3c111fc7b2fd2c2c8137bdac13f8d52bfb98&fromchange=7d8b346540db407b23ec4c538af659de47f8bcd8&selectedJob=292246677

Comment 2

[Andreea Pavel [:apavel]]

Mike, based on above results, I believe this is from bug 1617983, can you please take a look?

https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=os%2Cx%2C10.14%2Cdebug%2Cmochitests%2Ctest-macosx1014-64%2Fdebug-mochitest-browser-chrome-e10s-11%2Cm%28bc11%29&tochange=5b47cfcab1554c89400b7a6299ff0cabac4bda0c&fromchange=3004bc7597a088e181fbcb9a9044b8d952e9d45f&selectedJob=292614358 - backfill doesn't work below because of the build bustages.

Comment 3

[Intermittent Failures Robot]

34 failures in 5336 pushes (0.006 failures/push) were associated with this bug in the last 7 days.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 32
• mozilla-central: 2

Platform breakdown:

• macosx1014-64: 28
• macosx1014-64-shippable: 5
• windows7-32-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621173&startday=2020-03-09&endday=2020-03-15&tree=all

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Looking

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1621173 - Refactor browser_bug724239.js to take into account about:blank loads after a process flip. r?jaws!

With the privileged about content process enabled, we do a process flip
when navigating between about:newtab and http://example.com/, which means
that we might see the initial about:blank of the new DocShell load after
the process flip and interpret that as http://example.com/ loading.

This refactoring does two things:

1. Adds more documentation to E10SUtils.shouldLoadURIInBrowser, since it
   was being used kind of incorrectly in the test.
2. Makes it more explicit that we want http://example.com/ to load, and not
   any old page (like about:blank).

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Try seems to dig it: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3a5ebfa99f75763ef305980337a5ee68930611b8

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc307d95ba35
Refactor browser_bug724239.js to take into account about:blank loads after a process flip. r=jaws

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/dc307d95ba35

Comment 9

[Intermittent Failures Robot]

10 failures in 4955 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 10

Platform breakdown:

• macosx1014-64: 8
• macosx1014-64-shippable: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1621173&startday=2020-03-16&endday=2020-03-22&tree=all