1621203 - Stop using IsEqualNode in focus manager

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Boris Zbarsky [:bzbarsky]]

nsFocusManager::Focus has this bit:

    bool isRefocus = focusedNode && focusedNode->IsEqualNode(aElement);

which does a deep-tree compare of the two nodes. I checked with the authors of this code about a year ago and they said that this code likely just cares about pointer-equality, not a deep compare.

I was going to fix that, then it fell off my radar. :( Not going to get to it now, I suspect, though will give it a shot.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1621203 - Don't use IsEqualNode in nsFocusManager. r=smaug

There's no reason to.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4815ea533d31
Don't use IsEqualNode in nsFocusManager. r=smaug

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/4815ea533d31