1621259 - storage.StorageChange oldValue has the same value as newValue

Status: RESOLVED DUPLICATE of bug 1621162

(WebExtensions :: Storage, defect)

Description

[kernp25]

Attachment: manifest.zip

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:73.0) Gecko/20100101 Firefox/73.0

Steps to reproduce:

1. Load attached add-on
2. Open options page of the add-on
3. Click the save button (image 1)
4. Click the save button again (image 2)
5. Now check a checkbox and click the save button (image 3)
6. Click the save button again (image 4)

Actual results:

storage.StorageChange oldValue will have the same value as newValue.

Expected results:

storage.StorageChange oldValue should not change.

Comment 1

[kernp25]

Attachment: image1.png

Comment 2

[kernp25]

Attachment: image2.png

Comment 3

[kernp25]

Attachment: image3.png

Comment 4

[kernp25]

Attachment: image4.png

Comment 5

[kernp25]

Can you reproduce?

Comment 6

[Alex Cornestean]

Hello,

I’ve managed to reproduce the issue on the latest Nightly (76.0a1/20200311163942), Beta (75.0b2/20200310192828), Release (74.0/20200309095159) and ESR (68.6.0esr/20200305175243) under Windows 10 Pro 64-bit and MacOS Catalina 10.15.

Choosing to check the second checkbox will produce the exact results you provided in the attached screenshots, so I will not attach any of my own.

I’ve also checked whether the issue might be a regression (running a regression range from 2018-01-01 up to the current date), however, it seems that this issue in not one.

Comment 7

[Luca Greco [:rpl] [:luca] [:lgreco]]

needinfo-ing myself to investigate this.

Comment 8

[Luca Greco [:rpl] [:luca] [:lgreco]]

Hi kernp25,
At a first glance this issue looks like a duplicate of Bug 1621162 (which you also filed around the time you filed this one),
would you mind to briefly explain in which ways these two issues are different from your perspective?

Comment 9

[kernp25]

This bug is about oldValue will have the same value as newValue (if you reproduce the steps).
I don't think this is a duplicate of Bug 1621162.

I was using the same test add-on for both bugs. That's why you think, the bugs are duplicates?

Comment 10

[Luca Greco [:rpl] [:luca] [:lgreco]]

(In reply to kernp25 from comment #9)

This bug is about oldValue will have the same value as newValue (if you reproduce the steps).
I don't think this is a duplicate of Bug 1621162.

I was using the same test add-on for both bugs. That's why you think, the bugs are duplicates?

Given that (as mentioned in Bug 1621162) we are sending the onChanged event with old and new value for any value set (because we do not check if they are actually different), if the extension set a value to a key that is the same as the old value then oldValue and newValue are expected to be the same at that point.

Comment 11

[kernp25]

Can you close this bug?