1621283 - Assertion failure: mData in nsWebPDecoder.cpp:48

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect, P3)

Description

[Bob Clary [:bc] (inactive)]

1. https://www.iplaysoft.com/windows7-msdn-iso.html

2. Assert Windows only

Assertion failure: mData, at /builds/worker/checkouts/gecko/image/decoders/nsWebPDecoder.cpp:48
#01: mozilla::image::nsWebPDecoder::DoDecode(mozilla::image::SourceBufferIterator&, mozilla::image::IResumable*) [image/decoders/nsWebPDecoder.cpp:110]
#02: mozilla::image::Decoder::Decode(mozilla::image::IResumable*) [image/Decoder.cpp:133]
#03: mozilla::image::MetadataDecodingTask::Run() [image/IDecodingTask.cpp:152]
#04: mozilla::image::DecodePoolWorker::Run() [image/DecodePool.cpp:276]
#05: nsThread::ProcessNextEvent(bool, bool*) [xpcom/threads/nsThread.cpp:1222]

Bughunter first saw this on 2020-02-29.

Comment 1

[Bob Clary [:bc] (inactive)]

Windows only isn't quite true as bughunter also so this once with Ubuntu 19.10 debug asan build on https://anique.jp/.

Comment 2

[Jim Blandy :jimb]

Bob, do you have a crash report for this?

Comment 3

[Bob Clary [:bc] (inactive)]

Attachment: crash report from debug assert

yep

Comment 4

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is P3 (Backlog,) indicating it has been triaged, the bug's Severity is being updated to S3 (normal.)

Comment 5

[Andrew Osmond [:aosmond] (he/him)]

I think this might happen if you hit an OOM which sets an error in the SourceBuffer. We hit COMPLETE right away without any data pointer.

Comment 6

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1621283 - Ensure the WebP image decoder can handle source buffer errors.

If we hit an OOM or similar when creating a SourceBuffer for an image,
we will hit COMPLETE immediately as the next read that goes to the
SourceBuffer from a SourceBufferIterator. If the iterator has yet to do
a read, that means it will hit COMPLETE right away without giving
anything. This patch fixes the WebP decoder to handle this case, as well
as adds test cases for all of the current image decoders.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fed3695b6b6a
Ensure the WebP image decoder can handle source buffer errors. r=tnikkel

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/fed3695b6b6a