1621316 - Entering and Exiting RDM in rapid succesion it remains stuck in RDM

Status: VERIFIED FIXED

(DevTools :: Responsive Design Mode, defect, P2)

Description

[Rares Doghi, Desktop QA]

[Affected versions]
Firefox 76.0a1

[Affected platforms]
All

[Steps to reproduce]

1. Open the Firefox browser and reach any page (facebook.com)
2. Hit CTRL + SHIFT + M twice in rapid succession in order to Enter and Exit RDM.

[Expected result]
The user should be able to Exit RDM without issues.

[Actual result]
The user is stuck in RDM mode regardless if he tries to exit from the hamburger menu > web developer or reaching DevTools and clicking the RDM button.

Managed to get a regression range on this issue.

Last known GOOD:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3d076ae68a9411e4f412c90d2743987f7b916850&tochange=f2c8e5f773ae96eab3bb475f299f4203a7bc91a9
First known BAD:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=842e205217bf71e1bbba776c8a01240498a514d3&tochange=f2c8e5f773ae96eab3bb475f299f4203a7bc91a9

Comment 1

[Rares Doghi, Desktop QA]

I'm not sure what is the defect that causes the issue, Micah can you please take a look at the regression range I found ?

Comment 2

[Micah [:mtigley] (she/her)]

(In reply to Rares Doghi from comment #1)

I'm not sure what is the defect that causes the issue, Micah can you please take a look at the regression range I found ?

Sure, I'll take a look. I am also able to reproduce the issue.

Comment 4

[Micah [:mtigley] (she/her)]

Attachment: Bug 1621316 - Ensure that initializing RDM is completed before destroying

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a055be3cebe
Ensure that initializing RDM is completed before destroying r=jdescottes,bradwerth

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Comment 7

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/2a055be3cebe

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mtigley, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 9

[Micah [:mtigley] (she/her)]

Comment on attachment 9132391 [details]
Bug 1621316 - Ensure that initializing RDM is completed before destroying

Beta/Release Uplift Approval Request

• User impact if declined: User will be unable to exit RDM if they open and close the tool too quickly.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small change to RDM where the tool waits to be initialized before being destroyed when closed.
• String changes made/needed:

Comment 10

[Julien Cristau [:jcristau]]

Comment on attachment 9132391 [details]
Bug 1621316 - Ensure that initializing RDM is completed before destroying

rdm regression fix, approved for 75.0b6

Comment 11

[Rares Doghi, Desktop QA]

This issue is verified as fixed in our latest nightly build 76.0a1 (2020-03-17) on Windows 10, Mac Os and Ubuntu.

Comment 12

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/releases/mozilla-beta/rev/60a6a07af2a5

Comment 13

[Rares Doghi, Desktop QA]

This issue is verified as fixed in our latest Beta build 75.0b6 on Windows 10 , Ubuntu 18.04 and Mac Osx 10.15.