1621333 - <img loading=lazy> doesn't infer aspect ratio because of bug 1602047

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

There's no request, so we don't use the inferred aspect ratio... :(

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1621333 - Ensure aspect-ratio applies to lazy-loaded images. r=hiro,dholbert

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09e9434cb03d
Ensure aspect-ratio applies to lazy-loaded images. r=hiro

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/22170 for changes under testing/web-platform/tests

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/09e9434cb03d

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9132312 [details]
Bug 1621333 - Ensure aspect-ratio applies to lazy-loaded images. r=hiro,dholbert

Beta/Release Uplift Approval Request

• User impact if declined: Image lazy loading ships with 75, and this would cause jumpiness in pages using it unnecessarily.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Open https://www.tunetheweb.com/experiments/test_image_ratios.html and ensure that the second image doesn't jump.
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple change specific to the lazy-loading case.
• String changes made/needed: none

Comment 8

[Alin Ilea, Desktop Test Engineering]

Verified - Fixed in latest Nightly 76.0a1 (Build id: 20200316154314) using Windows 10 and Ubuntu 18.04.

Comment 9

[Julien Cristau [:jcristau]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #7)

• List of other uplifts needed: none

What about bug 1621511?

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Well maybe, though it's a test-only change, and it doesn't seem to have helped all that much unfortunately looking at the latest comments...

Comment 11

[Julien Cristau [:jcristau]]

Comment on attachment 9132312 [details]
Bug 1621333 - Ensure aspect-ratio applies to lazy-loaded images. r=hiro,dholbert

fix an issue with lazy loading before we enable it; approved for 75.0b6

Comment 12

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/releases/mozilla-beta/rev/28189d267700

Comment 13

[Alin Ilea, Desktop Test Engineering]

Verified - Fixed in latest Beta 75.0b6 (Build id: 20200319224147) using Windows 10 and Ubuntu 18.04.