1621336 - Why are we using LOAD_BACKGROUND for lazy-loaded images?

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

It seems to me they shouldn't be LOAD_BACKGROUND. Once they get loaded they should be high priority, right?

Comment 1

[Hiroyuki Ikezoe (:hiro)]

I don't have answers on this. Honza told me in a review comment, we can't change it once after we added the request into load group. https://phabricator.services.mozilla.com/D61437#inline-375510

I suppose you mean once the request gets started, no?

Comment 2

[Emilio Cobos Álvarez (:emilio)]

No, I mean that the request for these images should be high priority. We know they're about to be displayed to the user.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Ok, so you are suggesting a new load flag which doesn't block window.onload but is higher priority than LOAD_BACKGROUND, right? That makes sense to me.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Ah, d'oh, so I was wrong. I somehow thought that LOAD_BACKGROUND was about priority, not just about bypassing the loadgroup...

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1621336 - Add a comment about the usage of LOAD_BACKGROUND. r=hiro

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3c4767e25ca
Add a comment about the usage of LOAD_BACKGROUND. r=hiro

Comment 7

[Honza Bambas (:mayhemer)]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #4)

Ah, d'oh, so I was wrong. I somehow thought that LOAD_BACKGROUND was about priority, not just about bypassing the loadgroup...

Yes, only difference is that such marked requests don't block onload and as such don't spin the throbber. I believe the LOAD_BACKGROUND flag is in place here.

Comment 8

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/d3c4767e25ca