Closed Bug 1621336 Opened 4 years ago Closed 4 years ago

Why are we using LOAD_BACKGROUND for lazy-loaded images?

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla76
Tracking Status
firefox76 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

It seems to me they shouldn't be LOAD_BACKGROUND. Once they get loaded they should be high priority, right?

Flags: needinfo?(hikezoe.birchill)

I don't have answers on this. Honza told me in a review comment, we can't change it once after we added the request into load group. https://phabricator.services.mozilla.com/D61437#inline-375510

I suppose you mean once the request gets started, no?

Flags: needinfo?(hikezoe.birchill)

No, I mean that the request for these images should be high priority. We know they're about to be displayed to the user.

Ok, so you are suggesting a new load flag which doesn't block window.onload but is higher priority than LOAD_BACKGROUND, right? That makes sense to me.

Ah, d'oh, so I was wrong. I somehow thought that LOAD_BACKGROUND was about priority, not just about bypassing the loadgroup...

Assignee: nobody → emilio
Status: NEW → ASSIGNED
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d3c4767e25ca
Add a comment about the usage of LOAD_BACKGROUND. r=hiro

(In reply to Emilio Cobos Álvarez (:emilio) from comment #4)

Ah, d'oh, so I was wrong. I somehow thought that LOAD_BACKGROUND was about priority, not just about bypassing the loadgroup...

Yes, only difference is that such marked requests don't block onload and as such don't spin the throbber. I believe the LOAD_BACKGROUND flag is in place here.

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: