Closed
Bug 1621355
Opened 5 years ago
Closed 5 years ago
Un-hardcode dismiss tooltip
Categories
(Firefox :: New Tab Page, enhancement, P1)
Firefox
New Tab Page
Tracking
()
Tracking | Status | |
---|---|---|
firefox76 | --- | verified |
People
(Reporter: gsuntop, Assigned: gsuntop)
References
Details
Attachments
(1 file)
We should localize the dismiss tooltip copy.
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → gsuntop
Updated•5 years ago
|
Iteration: --- → 76.1 - Mar 9 - Mar 22
Priority: -- → P1
Updated•5 years ago
|
Blocks: collection-component
Updated•5 years ago
|
Iteration: 76.1 - Mar 9 - Mar 22 → 76.2 - Mar 23 - Apr 5
Assignee | ||
Comment 1•5 years ago
•
|
||
Test steps:
- Have the value of the pref
browser.newtabpage.activity-stream.discoverystream.endpoints
set tohttp,https
. - Have the value of the pref
browser.newtabpage.activity-stream.discoverystream.config
set to{"api_key_pref":"extensions.pocket.oAuthConsumerKey","collapsible":true,"enabled":true,"show_spocs":true,"hardcoded_layout":false,"personalized":true,"layout_endpoint":"https://e5e8374d-fffa-4a77-a604-31603852b6fd.mock.pstmn.io/1615081-layout"}
. - Have the value of the pref
browser.search.region
set toUS
. - Have the value of
browser.newtabpage.activity-stream.discoverystream.isCollectionDismissible
set totrue
- Hover over X on Collection and verify that "Remove" text appears in tooltip
Assignee | ||
Comment 2•5 years ago
|
||
Updated•5 years ago
|
Attachment #9136443 -
Attachment description: un-hardcoding dismiss tooltip → un-hardcoding dismiss tooltip - bz 1621355
Updated•5 years ago
|
Attachment #9136443 -
Attachment description: un-hardcoding dismiss tooltip - bz 1621355 → Bug 1621355 - un-hardcoding dismiss tooltip
Pushed by gsuntop@getpocket.com:
https://hg.mozilla.org/integration/autoland/rev/ab595a24ac9f
un-hardcoding dismiss tooltip r=fluent-reviewers,thecount,flod
Comment 4•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox76:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 76
Comment 5•5 years ago
•
|
||
I have verified that the issue is no longer reproducible on Firefox Nightly 76.0a1 (Build ID 20200401212659) using Windows 10 x64, Linux Ubuntu 18.04 and Mac OS x64.
While hovering over the "X" - collection dismiss option, the "Remove" text appears in tooltip;
Updated•5 years ago
|
Status: RESOLVED → VERIFIED
Updated•5 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•