Closed Bug 1621355 Opened 4 years ago Closed 4 years ago

Un-hardcode dismiss tooltip

Categories

(Firefox :: New Tab Page, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 76
Iteration:
76.2 - Mar 23 - Apr 5
Tracking Status
firefox76 --- verified

People

(Reporter: gsuntop, Assigned: gsuntop)

References

Details

Attachments

(1 file)

We should localize the dismiss tooltip copy.

Assignee: nobody → gsuntop
Iteration: --- → 76.1 - Mar 9 - Mar 22
Priority: -- → P1
Iteration: 76.1 - Mar 9 - Mar 22 → 76.2 - Mar 23 - Apr 5

Test steps:

  • Have the value of the pref browser.newtabpage.activity-stream.discoverystream.endpoints set to http,https.
  • Have the value of the pref browser.newtabpage.activity-stream.discoverystream.config set to {"api_key_pref":"extensions.pocket.oAuthConsumerKey","collapsible":true,"enabled":true,"show_spocs":true,"hardcoded_layout":false,"personalized":true,"layout_endpoint":"https://e5e8374d-fffa-4a77-a604-31603852b6fd.mock.pstmn.io/1615081-layout"}.
  • Have the value of the pref browser.search.region set to US.
  • Have the value of browser.newtabpage.activity-stream.discoverystream.isCollectionDismissible set to true
  • Hover over X on Collection and verify that "Remove" text appears in tooltip
Attachment #9136443 - Attachment description: un-hardcoding dismiss tooltip → un-hardcoding dismiss tooltip - bz 1621355
Attachment #9136443 - Attachment description: un-hardcoding dismiss tooltip - bz 1621355 → Bug 1621355 - un-hardcoding dismiss tooltip
Pushed by gsuntop@getpocket.com:
https://hg.mozilla.org/integration/autoland/rev/ab595a24ac9f
un-hardcoding dismiss tooltip r=fluent-reviewers,thecount,flod
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 76

I have verified that the issue is no longer reproducible on Firefox Nightly 76.0a1 (Build ID 20200401212659) using Windows 10 x64, Linux Ubuntu 18.04 and Mac OS x64.
While hovering over the "X" - collection dismiss option, the "Remove" text appears in tooltip;

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: