1621369 - Mapping OpenVR/Oculus controllers to WebXR spec and giving conversion for WebVR

Status: RESOLVED FIXED

(Core :: WebVR, task, P1)

Description

[Daosheng Mu[:daoshengmu]]

We currently follow button and axis order for WebVR. Due to the migration from WebVR to WebXR is happening, we wanna support WebXR controllers in more efficient ways. Therefore, we would support WebXR button/axis order by default in all VR sessions. Then, considering to do our conversation in VRDisplayClient::FireGamepadEvents (Because WebXR will be no longer to handle these Gamepad events.)

Comment 1

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1621369 - Part 1: Refactor OpenVR controller and adjust its button/axis order for WebXR.

Comment 2

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1621369 - Part 2: Replace OpenVRControllerType with VRControllerType in IPC.

Depends on D66677

Comment 3

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1621369 - Part 3: Adjust Oculus controller button/axis order for WebXR.

Depends on D66678

Comment 4

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1621369 - Part 4: Support WebXR to WebVR gamepad button/axis re-mapping.

Depends on D66679

Comment 5

[Daosheng Mu[:daoshengmu]]

There are several goals for this bug.

1. Refactoring OpenVR controller module. We have too much redundant code and most of them can use macro preprocessor to generate.
2. Due to we need to convert WebXR btn/axis order to WebVR based on controller's id. To avoid inefficient strcmp(), we would have to store a ControllerType flag in VRShmem, so we would like to reuse OpenVRControllerType to be VRControllerType, and we can consider to remove this flag once we decide to remove WebVR support.
3. Adjust Oculus controller btn/axis order to WebXR rules.
4. Giving a convert function to map WebXR btn/axis order to WebVR. After digging it into a bit, I find VRDisplayClient::FireGamepadEvents() only will be called in WebVR because WebXR will not add gamepad objects into GamepadManager. Doing this conversion in Gamepadpad is possible, but we have to add variables in PGamepadEventChannel, like ControllerType, and general gampads don't need this variable actually.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17182dacd40f
Part 1: Refactor OpenVR controller and adjust its button/axis order for WebXR. r=kip
https://hg.mozilla.org/integration/autoland/rev/a7b839503f7a
Part 2: Replace OpenVRControllerType with VRControllerType in IPC. r=kip
https://hg.mozilla.org/integration/autoland/rev/2174a2a5ece7
Part 3: Adjust Oculus controller button/axis order for WebXR. r=kip
https://hg.mozilla.org/integration/autoland/rev/4e4156f53e24
Part 4: Support WebXR to WebVR gamepad button/axis re-mapping. r=kip

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/17182dacd40f
https://hg.mozilla.org/mozilla-central/rev/a7b839503f7a
https://hg.mozilla.org/mozilla-central/rev/2174a2a5ece7
https://hg.mozilla.org/mozilla-central/rev/4e4156f53e24