1621399 - Add perfect negotiation wpt tests

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, task, P2)

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Bug 1621399 - Add RTCPeerConnection-perfect-negotiation.https.html wpt test.

Depends on D65980

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Try https://treeherder.mozilla.org/#/jobs?repo=try&revision=335eb26929b6a88ba5a0e985894e7a7ffbf28b94

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:jib, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fbc8ec8ecc0b
Add RTCPeerConnection-perfect-negotiation.https.html wpt test. r=bwc

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/23037 for changes under testing/web-platform/tests

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/23037
* Community-TC (pull_request) (https://community-tc.services.mozilla.com/tasks/groups/OGNfQP0wTXOoZWuCmzJflA)

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/fbc8ec8ecc0b

Comment 8

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Hi James, I added a wpt test in this bug with an ini file for Firefox failures, and then fixed them in bug 1628139, which landed together. Looks like this blocked upstream merge because the first version of the WPT (in this bug) does not pass Firefox upstream by itself. How do I solve it?

Comment 9

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

The second part of the WPT test failed to uplift in bug 1628139 comment 7.

Comment 10

[James Graham [:jgraham]]

So this didn't fail because of firefox failures as such, but because the stability checks failed in Chrome and Firefox.

Chrome:

10:28.80 INFO ## Unstable results ##
10:28.80 INFO |                            Test                            |                        Subtest                         |             Results             |                                                              Messages                                                             |
10:28.80 INFO |------------------------------------------------------------|--------------------------------------------------------|---------------------------------|-----------------------------------------------------------------------------------------------------------------------------------|
10:28.80 INFO | `/webrtc/RTCPeerConnection-perfect-negotiation.https.html` | `Perfect negotiation stress glare`                     | **FAIL: 2/10, TIMEOUT: 8/10**   | `assert_unreached: Error in iframe: Error: have direction expected sendonly but got null Reached unreachable code;Test timed out` |
10:28.80 INFO | `/webrtc/RTCPeerConnection-perfect-negotiation.https.html` | `Perfect negotiation stress glare with roles reversed` | **NOTRUN: 8/10, TIMEOUT: 2/10** | `Test timed out`                                                                                                                  |
10:28.80 INFO 

Firefox:

 1:18.37 INFO |                            Test                            |                            Subtest                            |          Results           |                              Messages                             |
 1:18.37 INFO |------------------------------------------------------------|---------------------------------------------------------------|----------------------------|-------------------------------------------------------------------|
 1:18.37 INFO | `/webrtc/RTCPeerConnection-perfect-negotiation.https.html` | `Perfect negotiation stress glare linear with roles reversed` | **FAIL: 1/10, PASS: 9/10** | `assert_equals: 42 transceivers on side B expected 42 but got 31` |
 1:18.37 INFO 

If there's a reason those failures are unavoidable I can force merge, but the ideal fix would be to land a followup patch on this bug to fix the intermittents.

Comment 11

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Right, when I said "failures" I should have said intermittent failures.

If there's a reason those failures are unavoidable I can force merge, but the ideal fix would be to land a followup patch on this bug to fix the intermittents.

I vote for force merge. The followup patches that fix the intermittents are bug 1628139 comment 7 and are already on central.

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by jgraham