1621446 - Telemetry for user-visible signon.* preferences

Status: VERIFIED FIXED

(Toolkit :: Password Manager, task, P2)

Description

[Matthew N. [:MattN]]

The following are the four preferences visible at about:preferences#privacy-logins and we currently don't know how many people are disabling these features, we can only approximate them by correlation with events.

• signon.management.page.breach-alerts.enabled
• signon.autofillForms
• signon.rememberSignons
• signon.generation.enabled

It would help us to understand the impact of our changes and improve the accuracy of our denominators for analysis if we knew whether users have turned off the above features.

Comment 1

[Matthew N. [:MattN]]

Attachment: Request for data collection review form

Comment 2

[Matthew N. [:MattN]]

Attachment: Bug 1621446 - Environment telemetry for user-visible signon.* preferences. r=tdsmith

Comment 3

[Tim Smith (inactive) 👨‍🔬 [:tdsmith]]

Comment on attachment 9132402 [details]
Request for data collection review form

1) Is there or will there be **documentation** that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, presence in that array in TelemetryEnvironment.jsm is our present documentation standard. Thanks for adding the searchfox link from the source-tree-docs.

2) Is there a control mechanism that allows the user to turn the data collection on and off? (Note, for data collection not needed for security purposes, Mozilla provides such a control mechanism)

Yes, the Firefox telemetry opt-out.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, MattN.

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, interaction data.

5) Is the data collection request for default-on or default-off?

Default-on.

6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc.  See the appendix for more details)?

No.

7) Is the data collection covered by the existing Firefox privacy notice? 

Yes.

8) Does there need to be a check-in in the future to determine whether to renew the data?

No, this is a permanent collection.

9) Does the data collection use a third-party collection tool?

No.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2bba09f7832
Environment telemetry for user-visible signon.* preferences. r=janerik

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/a2bba09f7832

Comment 6

[Matthew N. [:MattN]]

Comment on attachment 9132403 [details]
Bug 1621446 - Environment telemetry for user-visible signon.* preferences. r=tdsmith

Beta/Release Uplift Approval Request

• User impact if declined: Users may dislike Fx76 changes to breach alerts and password generation but Mozilla won't know that people are turning off the feature as a result.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The telemetry environment userPrefs system should be well tested as it has been in use for years. All I did was add 4 preferences to an existing list.
• String changes made/needed: None

Comment 7

[Matthew N. [:MattN]]

I verified using the live data (telemetry_live.main_v4) submitted by build 20200312035749: 4fd5c458be4c3bc2d1f22bd575667104a5d173fe.

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 9132403 [details]
Bug 1621446 - Environment telemetry for user-visible signon.* preferences. r=tdsmith

approved for 75.0b3

Comment 9

[Oana Pop-Rus]

https://hg.mozilla.org/releases/mozilla-beta/rev/affd6f8b6822