1621474 - Minor cleanups in WebRender animation code

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task, P3)

Description

[Hiroyuki Ikezoe (:hiro)]

there are some redundant code I'd like to clean up. There may be more room though.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1621474 - Drop into() calls for LayoutTransform in WrTransformProperty. r?kats

It's not necessary to be converted, it's simply copied.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1621474 - Add a generic WrAnimationPropertyValue. r?kats

Depends on D66328

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1621474 - Factor out a generic function to convert WrAnimationPropertyValue<T> array into Vec<PropertyValue<T>>. r?kats

Depends on D66329

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1621474 - Introduce WrAnimations struct to reduce the numbers of arguments of SampleAnimations. r?kats

Depends on D66330

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1621474 - Use Variant::match in AnimatedValue iterations. r?kats

Depends on D66331

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f0d44986dcb
Drop into() calls for LayoutTransform in WrTransformProperty. r=kats
https://hg.mozilla.org/integration/autoland/rev/9fa301ad4bcc
Add a generic WrAnimationPropertyValue. r=kats
https://hg.mozilla.org/integration/autoland/rev/d94e42873dd0
Factor out a generic function to convert WrAnimationPropertyValue<T> array into Vec<PropertyValue<T>>. r=kats
https://hg.mozilla.org/integration/autoland/rev/2f9c6c600774
Introduce WrAnimations struct to reduce the numbers of arguments of SampleAnimations. r=kats
https://hg.mozilla.org/integration/autoland/rev/ae2a8d6e0c95
Use Variant::match in AnimatedValue iterations. r=kats

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/6f0d44986dcb
https://hg.mozilla.org/mozilla-central/rev/9fa301ad4bcc
https://hg.mozilla.org/mozilla-central/rev/d94e42873dd0
https://hg.mozilla.org/mozilla-central/rev/2f9c6c600774
https://hg.mozilla.org/mozilla-central/rev/ae2a8d6e0c95