1621476 - Firefox preview doesn't support Webauthn but PublicKeyCredential return true

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P1)

Description

[mockinaeon]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.132 Safari/537.36

Steps to reproduce:

https://github.com/mozilla-mobile/fenix/issues/9090
Attempt to login a website using security key(webauthn) as two factor.

Actual results:

As we are implementing two factor security key using webauthn, we have tested many browser on different devices. We tried firefox preview on Android, it seems window.PublicKeyCredential is returning something but not undefined, then our app render the wrong information but not showing the popup, which is confusing.

Expected results:

show not support webauthn message based on a javascript block checking window.PublicKeyCredential which should be null/undefined.

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

JC do you have any thoughts about this behavior? Ideally Firefox Preview would support the UI for webauthn. Should we return false on this check for now?

Comment 2

[J.C. Jones [:jcj] (he/him)]

Fenix needs to set the preference back to false to disable this until Fenix re-adds the support for WebAuthn.

Fenix should set the prefs security.webauth.webauthn_enable_android_fido2 and security.webauth.webauthn to false.

Comment 3

[Kevin Brosnan [Ex-Mozilla]]

I believe GeckoView controls that as there is not a prefs API.

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1621476 - Turn off WebAuthn for now in GeckoView

We'll turn it back on once it's actually supported.

Comment 5

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1621476 - Disable WebAuthn on GeckoView

We'll enable it once it's actually supported.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fac88f2cec9c
Disable WebAuthn on GeckoView r=jcj

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5fd1a87f522b
Backed out changeset fac88f2cec9c for causing failures in test_interfaces_secureContext.html

Comment 8

[Alexandru Michis [:malexandru]]

Backed out changeset fac88f2cec9c for causing failures in test_interfaces_secureContext.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/5fd1a87f522beee0275a77653fa6fa73c420b9cb

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=android%2C7.0%2Cx86-64%2Copt&fromchange=672e6b9a082343085761a4088cbe5e44d19c6f72&tochange=07c3e069a5c9ba944528ec93129d33f55d999b7b&failure_classification_id=2&selectedJob=292736213

Failure log:

• mochitest: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=292736267&repo=autoland&lineNumber=4609
• wpt: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=292736213&repo=autoland&lineNumber=1832

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f0fdfd8fc57
Disable WebAuthn on GeckoView r=jcj,smaug

Comment 10

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/2f0fdfd8fc57