1621576 - Add a linter rule to check unbalanced addObserver/removeObserver

Status: RESOLVED FIXED

(DevTools :: Framework, task, P3)

Description

[Julian Descottes [:jdescottes]]

Follow up to the investigation in Bug 1609201.

Services' addObserver (obs, prefs) APIs should always have a corresponding removeObserver call to avoid leaks.

We already have a balanced-listener eslint rule, we can make a slightly different version to handle addObserver/removeObserver.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1621576 - Add a linter rule to check unbalanced addObserver/removeObserver

Depends on D66369

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1621576 - Apply mozilla/balanced-observers eslint rule in devtools

Depends on D66378

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eddc5606b9ba
Add a linter rule to check unbalanced addObserver/removeObserver r=Standard8
https://hg.mozilla.org/integration/autoland/rev/05ebd9c6bcc9
Apply mozilla/balanced-observers eslint rule in devtools r=ochameau

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/eddc5606b9ba
https://hg.mozilla.org/mozilla-central/rev/05ebd9c6bcc9